From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: bp@suse.de
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, david.vrabel@citrix.com,
konrad.wilk@oracle.com, boris.ostrovsky@oracle.com
Subject: [PATCH] x86, microcode: Don't initialize microcode code on paravirt
Date: Mon, 1 Dec 2014 16:27:44 -0500 [thread overview]
Message-ID: <1417469264-31470-1-git-send-email-boris.ostrovsky@oracle.com> (raw)
Paravirtual guests are not expected to load microcode into processors
and therefore it is not necessary to initialize microcode loading
logic.
In fact, under certain circumstances initializing this logic may cause
the guest to crash. Specifically, 32-bit kernels use __pa_nodebug()
macro which does not work in Xen (the code path that leads to this macro
happens during resume when we call mc_bp_resume()->load_ucode_ap()
->check_loader_disabled_ap())
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
---
arch/x86/kernel/cpu/microcode/core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/cpu/microcode/core.c b/arch/x86/kernel/cpu/microcode/core.c
index 2ce9051..ebd232d 100644
--- a/arch/x86/kernel/cpu/microcode/core.c
+++ b/arch/x86/kernel/cpu/microcode/core.c
@@ -557,7 +557,7 @@ static int __init microcode_init(void)
struct cpuinfo_x86 *c = &cpu_data(0);
int error;
- if (dis_ucode_ldr)
+ if (paravirt_enabled() || dis_ucode_ldr)
return 0;
if (c->x86_vendor == X86_VENDOR_INTEL)
--
1.7.1
next reply other threads:[~2014-12-01 21:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 21:27 Boris Ostrovsky [this message]
2014-12-01 21:57 ` Konrad Rzeszutek Wilk
2014-12-01 22:12 ` Paolo Bonzini
2014-12-01 22:31 ` Borislav Petkov
2014-12-01 22:00 ` Borislav Petkov
2014-12-01 22:31 ` Boris Ostrovsky
2014-12-01 22:37 ` Borislav Petkov
2014-12-02 14:36 ` Boris Ostrovsky
2014-12-02 14:58 ` Borislav Petkov
2014-12-02 1:28 ` Greg KH
2014-12-08 9:43 ` [tip:x86/microcode] x86, microcode: Don' t " tip-bot for Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417469264-31470-1-git-send-email-boris.ostrovsky@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=bp@suse.de \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®