From: Zidan Wang <b50113@freescale.com>
To: <broonie@kernel.org>
Cc: <lgirdwood@gmail.com>, <perex@perex.cz>, <tiwai@suse.de>,
<lars@metafoo.de>, <ckeepax@opensource.wolfsonmicro.com>,
<Li.Xiubo@freescale.com>, <patches@opensource.wolfsonmicro.com>,
<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
Zidan Wang <b50113@freescale.com>
Subject: [alsa-devel][PATCH] ASoC: wm8960: Let wm8960 codec driver manage its own MCLK
Date: Wed, 3 Dec 2014 19:00:38 +0800 [thread overview]
Message-ID: <1417604438-28362-1-git-send-email-b50113@freescale.com> (raw)
When we want to use wm8960 codec, we should enable its MCLK in machine
driver. It's reasonable for wm8960 codec driver to manage its own MCLK to
save power.
Enable runtime power management, and auto enable/disable MCLK in pm_runtime
resume and suspend. When wm8960 codec is being used, it will triger resume()
to enable MCLK. When codec is not being used, it will triger suspend() to
disable MCLK and power down PLL.
Signed-off-by: Zidan Wang <b50113@freescale.com>
---
include/sound/wm8960.h | 1 +
sound/soc/codecs/wm8960.c | 51 +++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 52 insertions(+)
diff --git a/include/sound/wm8960.h b/include/sound/wm8960.h
index e8ce8ee..d7e84ed 100644
--- a/include/sound/wm8960.h
+++ b/include/sound/wm8960.h
@@ -16,6 +16,7 @@
#define WM8960_DRES_MAX 3
struct wm8960_data {
+ struct clk *mclk;
bool capless; /* Headphone outputs configured in capless mode */
bool shared_lrclk; /* DAC and ADC LRCLKs are wired together */
diff --git a/sound/soc/codecs/wm8960.c b/sound/soc/codecs/wm8960.c
index 031a1ae..6a529b1 100644
--- a/sound/soc/codecs/wm8960.c
+++ b/sound/soc/codecs/wm8960.c
@@ -15,6 +15,8 @@
#include <linux/init.h>
#include <linux/delay.h>
#include <linux/pm.h>
+#include <linux/clk.h>
+#include <linux/pm_runtime.h>
#include <linux/i2c.h>
#include <linux/slab.h>
#include <sound/core.h>
@@ -988,6 +990,8 @@ static void wm8960_set_pdata_from_of(struct i2c_client *i2c,
if (of_property_read_bool(np, "wlf,shared-lrclk"))
pdata->shared_lrclk = true;
+
+ pdata->mclk = devm_clk_get(&i2c->dev, NULL);
}
static int wm8960_i2c_probe(struct i2c_client *i2c,
@@ -1011,6 +1015,14 @@ static int wm8960_i2c_probe(struct i2c_client *i2c,
else if (i2c->dev.of_node)
wm8960_set_pdata_from_of(i2c, &wm8960->pdata);
+ /* Mark the mclk pointer to NULL if no mclk assigned */
+ if (IS_ERR(wm8960->pdata.mclk)) {
+ /* But do not ignore the request for probe defer */
+ if (PTR_ERR(wm8960->pdata.mclk) == -EPROBE_DEFER)
+ return -EPROBE_DEFER;
+ wm8960->pdata.mclk = NULL;
+ }
+
ret = wm8960_reset(wm8960->regmap);
if (ret != 0) {
dev_err(&i2c->dev, "Failed to issue reset\n");
@@ -1041,6 +1053,9 @@ static int wm8960_i2c_probe(struct i2c_client *i2c,
i2c_set_clientdata(i2c, wm8960);
+ pm_runtime_enable(&i2c->dev);
+ pm_request_idle(&i2c->dev);
+
ret = snd_soc_register_codec(&i2c->dev,
&soc_codec_dev_wm8960, &wm8960_dai, 1);
@@ -1053,6 +1068,41 @@ static int wm8960_i2c_remove(struct i2c_client *client)
return 0;
}
+#ifdef CONFIG_PM_RUNTIME
+static int wm8960_runtime_resume(struct device *dev)
+{
+ struct wm8960_priv *wm8960 = dev_get_drvdata(dev);
+ int ret;
+
+ if (wm8960->pdata.mclk) {
+ ret = clk_prepare_enable(wm8960->pdata.mclk);
+ if (ret) {
+ dev_err(dev, "Failed to enable MCLK: %d\n", ret);
+ return ret;
+ }
+ }
+
+ return 0;
+}
+
+static int wm8960_runtime_suspend(struct device *dev)
+{
+ struct wm8960_priv *wm8960 = dev_get_drvdata(dev);
+
+ /* Power down PLL to save power */
+ regmap_update_bits(wm8960->regmap, WM8960_POWER2, 0x1, 0);
+
+ if (wm8960->pdata.mclk)
+ clk_disable_unprepare(wm8960->pdata.mclk);
+
+ return 0;
+}
+#endif
+
+static const struct dev_pm_ops wm8960_pm = {
+ SET_RUNTIME_PM_OPS(wm8960_runtime_suspend, wm8960_runtime_resume, NULL)
+};
+
static const struct i2c_device_id wm8960_i2c_id[] = {
{ "wm8960", 0 },
{ }
@@ -1070,6 +1120,7 @@ static struct i2c_driver wm8960_i2c_driver = {
.name = "wm8960",
.owner = THIS_MODULE,
.of_match_table = wm8960_of_match,
+ .pm = &wm8960_pm,
},
.probe = wm8960_i2c_probe,
.remove = wm8960_i2c_remove,
--
1.9.1
next reply other threads:[~2014-12-03 11:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-03 11:00 Zidan Wang [this message]
2014-12-03 12:41 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417604438-28362-1-git-send-email-b50113@freescale.com \
--to=b50113@freescale.com \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®