mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: "Joshua I. James" <joshua@cybercrimetech.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: kernel: fixed style errors in pid.c
Date: Thu, 04 Dec 2014 22:39:42 -0800	[thread overview]
Message-ID: <1417761582.2721.35.camel@perches.com> (raw)
In-Reply-To: <1417760858-26831-1-git-send-email-Joshua@cybercrimetech.com>

On Fri, 2014-12-05 at 15:27 +0900, Joshua I. James wrote:
> Fixed style errors identified by checkpatch.

Your subject is not correct.

This is not staging.

Please submit patches only for drivers/staging until
until you are _very_ familiar with kernel style.

And most whitespace only changes to kernel/... are not
particularly welcomed by the most experienced kernel
developers.

> diff --git a/kernel/pid.c b/kernel/pid.c
[]
> @@ -471,8 +478,10 @@ EXPORT_SYMBOL_GPL(get_task_pid);
>  struct task_struct *get_pid_task(struct pid *pid, enum pid_type type)
>  {
>  	struct task_struct *result;
> +
>  	rcu_read_lock();
>  	result = pid_task(pid, type);
> +

Unnecessary blank line added here.

btw: using scripts/checkpatch.pl --fix-inplace --strict
would have been better.


      reply	other threads:[~2014-12-05  6:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-05  6:27 Joshua I. James
2014-12-05  6:39 ` Joe Perches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1417761582.2721.35.camel@perches.com \
    --to=joe@perches.com \
    --cc=joshua@cybercrimetech.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome