From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
To: "Linus Walleij" <linus.walleij@linaro.org>,
"Alexandre Courbot" <gnurou@gmail.com>,
"Michal Simek" <michal.simek@xilinx.com>,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Subject: [PATCH 2/4] gpio/xilinx: Convert the driver to platform device interface
Date: Mon, 8 Dec 2014 16:07:54 +0100 [thread overview]
Message-ID: <1418051276-5476-3-git-send-email-ricardo.ribalda@gmail.com> (raw)
In-Reply-To: <1418051276-5476-1-git-send-email-ricardo.ribalda@gmail.com>
This way we do not need to transverse the device tree manually and we
support hot plugged devices.
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
drivers/gpio/gpio-xilinx.c | 27 ++++++++++++++-------------
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
index 9483950..1199a31 100644
--- a/drivers/gpio/gpio-xilinx.c
+++ b/drivers/gpio/gpio-xilinx.c
@@ -174,16 +174,16 @@ static void xgpio_save_regs(struct of_mm_gpio_chip *mm_gc)
/**
* xgpio_of_probe - Probe method for the GPIO device.
- * @np: pointer to device tree node
*
* This function probes the GPIO device in the device tree. It initializes the
* driver data structure. It returns 0, if the driver is bound to the GPIO
* device, or a negative value if there is an error.
*/
-static int xgpio_of_probe(struct device_node *np)
+static int xgpio_probe(struct platform_device *pdev)
{
struct xgpio_instance *chip;
int status = 0;
+ struct device_node *np = pdev->dev.of_node;
const u32 *tree_info;
u32 ngpio;
@@ -210,6 +210,7 @@ static int xgpio_of_probe(struct device_node *np)
spin_lock_init(&chip->gpio_lock);
+ chip->mmchip.gc.dev = &pdev->dev;
chip->mmchip.gc.direction_input = xgpio_dir_in;
chip->mmchip.gc.direction_output = xgpio_dir_out;
chip->mmchip.gc.get = xgpio_get;
@@ -255,6 +256,7 @@ static int xgpio_of_probe(struct device_node *np)
spin_lock_init(&chip->gpio_lock);
+ chip->mmchip.gc.dev = &pdev->dev;
chip->mmchip.gc.direction_input = xgpio_dir_in;
chip->mmchip.gc.direction_output = xgpio_dir_out;
chip->mmchip.gc.get = xgpio_get;
@@ -286,19 +288,18 @@ static const struct of_device_id xgpio_of_match[] = {
{ /* end of list */ },
};
-static int __init xgpio_init(void)
-{
- struct device_node *np;
-
- for_each_matching_node(np, xgpio_of_match)
- xgpio_of_probe(np);
+MODULE_DEVICE_TABLE(of, xgpio_of_match);
- return 0;
-}
+static struct platform_driver xgpio_plat_driver = {
+ .probe = xgpio_probe,
+ .driver = {
+ .name = "gpio-xilinx",
+ .owner = THIS_MODULE,
+ .of_match_table = xgpio_of_match,
+ },
+};
-/* Make sure we get initialized before anyone else tries to use us */
-subsys_initcall(xgpio_init);
-/* No exit call at the moment as we cannot unregister of GPIO chips */
+module_platform_driver(xgpio_plat_driver);
MODULE_AUTHOR("Xilinx, Inc.");
MODULE_DESCRIPTION("Xilinx GPIO driver");
--
2.1.3
next prev parent reply other threads:[~2014-12-08 15:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-08 15:07 [PATCH 0/4] Add support for PCI mapped devices and rmmod Ricardo Ribalda Delgado
2014-12-08 15:07 ` [PATCH 1/4] gpio/xilinx: remove offset property Ricardo Ribalda Delgado
2014-12-10 10:41 ` Alexandre Courbot
2014-12-08 15:07 ` Ricardo Ribalda Delgado [this message]
2014-12-10 10:49 ` [PATCH 2/4] gpio/xilinx: Convert the driver to platform device interface Alexandre Courbot
2014-12-10 13:07 ` Ricardo Ribalda Delgado
2014-12-10 13:09 ` Alexandre Courbot
2014-12-10 13:22 ` Ricardo Ribalda Delgado
2014-12-08 15:07 ` [PATCH 3/4] gpio-xilinx: Implement remove callback Ricardo Ribalda Delgado
2014-12-08 15:07 ` [PATCH 4/4] gpio-xilinx: Add support for X86 Arch Ricardo Ribalda Delgado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418051276-5476-3-git-send-email-ricardo.ribalda@gmail.com \
--to=ricardo.ribalda@gmail.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=soren.brinkmann@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®