From: Joe Perches <joe@perches.com>
To: Zeng Tao <prime.zeng@huawei.com>
Cc: gregkh@linuxfoundation.org, john.stultz@linaro.org,
ccross@android.com, rebecca@android.com,
fabio.estevam@freescale.com, tranmanphong@gmail.com,
benjamin.gaignard@linaro.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: ion: ion_cma_heap: remove ion_cma_get_sgtable
Date: Mon, 08 Dec 2014 17:29:18 -0800 [thread overview]
Message-ID: <1418088558.15957.5.camel@perches.com> (raw)
In-Reply-To: <1418087980-221566-1-git-send-email-prime.zeng@huawei.com>
On Tue, 2014-12-09 at 09:19 +0800, Zeng Tao wrote:
> Remove the temporary code ion_cma_get_sgtable,
> use dma_common_get_sgtable instead
[]
> diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c
[]
> @@ -91,7 +73,7 @@ static int ion_cma_allocate(struct ion_heap *heap, struct ion_buffer *buffer,
> if (!info->table)
> goto free_mem;
>
> - if (ion_cma_get_sgtable
> + if (dma_common_get_sgtable
> (dev, info->table, info->cpu_addr, info->handle, len))
> goto free_table;
> /* keep this for memory release */
somewhat unrelated trivia:
It'd conform a bit more to kernel style to
write this with at least one argument on the
same line as the function like:
if (dma_common_get_sgtable(dev, info->table, info->cpu_addr,
info->handle, len))
goto free_table;
prev parent reply other threads:[~2014-12-09 1:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 1:19 Zeng Tao
2014-12-09 1:29 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418088558.15957.5.camel@perches.com \
--to=joe@perches.com \
--cc=benjamin.gaignard@linaro.org \
--cc=ccross@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=fabio.estevam@freescale.com \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prime.zeng@huawei.com \
--cc=rebecca@android.com \
--cc=tranmanphong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome