mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mike Looijmans <mike.looijmans@topic.nl>
To: broonie@kernel.org, lgirdwood@gmail.com
Cc: linux-kernel@vger.kernel.org, Mike Looijmans <mike.looijmans@topic.nl>
Subject: [PATCH 1/2] drivers/regulator/core.c: Don't print error on EPROBE_DEFER
Date: Tue,  9 Dec 2014 14:12:43 +0100	[thread overview]
Message-ID: <1418130764-22440-1-git-send-email-mike.looijmans@topic.nl> (raw)

If a regulator depends on another regulator that happens to be called
later, the kernel always prints a message like this:
  reg-fixed-voltage regulator_sd1: Failed to find supply vin
Since the deferral is not something fatal, nor even something the user
may need to be aware about, reduce the message to debug level.

This fixes a storm of error messages at boot when a board has a power
regulator on an I2C bus which powers GPIO controlled regulators for
example.

Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
---
 drivers/regulator/core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index e225711..9fb66cd 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -3715,7 +3715,7 @@ regulator_register(const struct regulator_desc *regulator_desc,
 			ret = 0;
 			goto add_dev;
 		} else if (!r) {
-			dev_err(dev, "Failed to find supply %s\n", supply);
+			dev_dbg(dev, "Failed to find supply %s\n", supply);
 			ret = -EPROBE_DEFER;
 			goto scrub;
 		}
-- 
1.7.9.5


             reply	other threads:[~2014-12-09 13:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-09 13:12 Mike Looijmans [this message]
2014-12-09 13:12 ` [PATCH 2/2] regulator/fixed.c: Don't report EPROBE_DEFER errors Mike Looijmans
2014-12-09 16:14 ` [PATCH 1/2] drivers/regulator/core.c: Don't print error on EPROBE_DEFER Mark Brown
2014-12-09 18:12   ` Mike Looijmans
2014-12-09 18:48     ` Mark Brown
2014-12-09 19:14       ` Joe Perches
2014-12-09 19:17         ` Mark Brown
2014-12-16 10:27       ` Mike Looijmans
2014-12-16 11:29         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418130764-22440-1-git-send-email-mike.looijmans@topic.nl \
    --to=mike.looijmans@topic.nl \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®