mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>,
	devel@linuxdriverproject.org, linux-kernel@vger.kernel.org,
	Dexuan Cui <decui@microsoft.com>
Subject: [PATCH 2/5] Tools: hv: remove unused bytes_written from kvp_update_file()
Date: Tue,  9 Dec 2014 16:48:20 +0100	[thread overview]
Message-ID: <1418140103-11854-3-git-send-email-vkuznets@redhat.com> (raw)
In-Reply-To: <1418140103-11854-1-git-send-email-vkuznets@redhat.com>

fwrite() does not actually return the number of bytes written and
this value is being ignored anyway and ferror() is being called to
check for an error. As we assign to this variable and never use it
we get the following compile-time warning:
hv_kvp_daemon.c:149:9: warning: variable ‘bytes_written’ set but not used [-Wunused-but-set-variable]

Remove bytes_written completely.

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
---
 tools/hv/hv_kvp_daemon.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c
index 6a6432a..5a274ca 100644
--- a/tools/hv/hv_kvp_daemon.c
+++ b/tools/hv/hv_kvp_daemon.c
@@ -147,7 +147,6 @@ static void kvp_release_lock(int pool)
 static void kvp_update_file(int pool)
 {
 	FILE *filep;
-	size_t bytes_written;
 
 	/*
 	 * We are going to write our in-memory registry out to
@@ -163,8 +162,7 @@ static void kvp_update_file(int pool)
 		exit(EXIT_FAILURE);
 	}
 
-	bytes_written = fwrite(kvp_file_info[pool].records,
-				sizeof(struct kvp_record),
+	fwrite(kvp_file_info[pool].records, sizeof(struct kvp_record),
 				kvp_file_info[pool].num_records, filep);
 
 	if (ferror(filep) || fclose(filep)) {
-- 
1.9.3


  parent reply	other threads:[~2014-12-09 15:48 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-09 15:48 [PATCH 0/5] Tools: hv: fix compiler warnings and do minor cleanup Vitaly Kuznetsov
2014-12-09 15:48 ` [PATCH 1/5] Tools: hv: add mising fcopyd to the Makefile Vitaly Kuznetsov
2014-12-10 18:52   ` KY Srinivasan
2014-12-09 15:48 ` Vitaly Kuznetsov [this message]
2014-12-10 18:49   ` [PATCH 2/5] Tools: hv: remove unused bytes_written from kvp_update_file() KY Srinivasan
2014-12-09 15:48 ` [PATCH 3/5] Tools: hv: address compiler warnings for hv_kvp_daemon.c Vitaly Kuznetsov
2014-12-10 18:51   ` KY Srinivasan
2014-12-09 15:48 ` [PATCH 4/5] Tools: hv: address compiler warnings for hv_fcopy_daemon.c Vitaly Kuznetsov
2014-12-10 18:55   ` KY Srinivasan
2014-12-09 15:48 ` [PATCH 5/5] Tools: hv: do not add redundant '/' in hv_start_fcopy() Vitaly Kuznetsov
2014-12-10 18:54   ` KY Srinivasan
2014-12-10  2:58 ` [PATCH 0/5] Tools: hv: fix compiler warnings and do minor cleanup Dexuan Cui
2014-12-10  9:22   ` Vitaly Kuznetsov
2014-12-10 14:48     ` gregkh
2014-12-10 17:50       ` KY Srinivasan
2015-01-08 16:02         ` Vitaly Kuznetsov
2015-01-08 17:04           ` KY Srinivasan
2015-01-09 20:47             ` gregkh
2015-01-09 20:58               ` KY Srinivasan
2015-01-09 21:02                 ` gregkh
2015-01-09 21:08                   ` KY Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418140103-11854-3-git-send-email-vkuznets@redhat.com \
    --to=vkuznets@redhat.com \
    --cc=decui@microsoft.com \
    --cc=devel@linuxdriverproject.org \
    --cc=haiyangz@microsoft.com \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®