mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Karol Wrona <k.wrona@samsung.com>
To: Jonathan Cameron <jic23@kernel.org>,
	linux-iio@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
	linux-kernel@vger.kernel.org
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Karol Wrona <wrona.vy@gmail.com>,
	Karol Wrona <k.wrona@samsung.com>
Subject: [RFC PATCH 0/2] iio: kfifo: Add resource management alloc/free
Date: Tue, 09 Dec 2014 20:29:43 +0100	[thread overview]
Message-ID: <1418153385-18212-1-git-send-email-k.wrona@samsung.com> (raw)

This is RFC because I felt a bit confused while devm_alloc/free adding.
It applies on next but I've tested it partialy on 3.16.  It can cause some
problemsi with several drivers so it does not fit for now. 

iio kfifo alloc takes one argument struct iio_dev * which is not used.
iio_buffer is attached by external function.  In such situation resource 
management alloc can be implemented in two ways:
1. indio_dev ptr in iio_kfifo_alloc stays and devm_ functions have to
provide it but it is still unused.
2.  As there are a few drivers which use kfifo it can be removed and 
iio_kfifo_allocate refactored.

I apologise if I missed something and it was done in such way intentionally.



Karol Wrona (2):
  iio: kfifo: Remove unused argument in iio_kfifo_allocate
  iio: kfifo: Add resource management devm_iio_kfifo_allocate/free

 drivers/iio/kfifo_buf.c       |   58 ++++++++++++++++++++++++++++++++++++++++-
 include/linux/iio/kfifo_buf.h |    5 +++-
 2 files changed, 61 insertions(+), 2 deletions(-)

-- 
1.7.9.5


             reply	other threads:[~2014-12-09 19:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-09 19:29 Karol Wrona [this message]
2014-12-09 19:29 ` [RFC PATCH 1/2] iio: kfifo: Remove unused argument in iio_kfifo_allocate Karol Wrona
2014-12-18 16:42   ` Lars-Peter Clausen
2014-12-09 19:29 ` [RFC PATCH 2/2] iio: kfifo: Add resource management devm_iio_kfifo_allocate/free Karol Wrona
2014-12-18 16:46   ` Lars-Peter Clausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418153385-18212-1-git-send-email-k.wrona@samsung.com \
    --to=k.wrona@samsung.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wrona.vy@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®