From: Andrzej Hajda <a.hajda@samsung.com>
To: linux-kernel@vger.kernel.org (open list)
Cc: Andrzej Hajda <a.hajda@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mike Turquette <mturquette@linaro.org>,
Russell King <linux@arm.linux.org.uk>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Inki Dae <inki.dae@samsung.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org (moderated list:ARM/CLKDEV
SUPPORT), linux-gpio@vger.kernel.org (open list:GPIO SUBSYSTEM),
dri-devel@lists.freedesktop.org (open list:DRM PANEL DRIVERS),
linux-samsung-soc@vger.kernel.org (moderated list:ARM/S5P EXYNOS
AR...),
devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND...),
boris.brezillon@free-electrons.com
Subject: [RFC 06/15] gpio: add restrack support
Date: Wed, 10 Dec 2014 16:48:24 +0100 [thread overview]
Message-ID: <1418226513-14105-7-git-send-email-a.hajda@samsung.com> (raw)
In-Reply-To: <1418226513-14105-1-git-send-email-a.hajda@samsung.com>
GPIO supports different methods of lookup.
The patch adds restrack support only to DT based GPIOs.
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
drivers/gpio/gpiolib.c | 81 +++++++++++++++++++++++++++++++++++++++++++
include/linux/gpio/consumer.h | 4 +++
include/linux/restrack.h | 1 +
3 files changed, 86 insertions(+)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 78fcec9..5d85e20 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -15,6 +15,7 @@
#include <linux/acpi.h>
#include <linux/gpio/driver.h>
#include <linux/gpio/machine.h>
+#include <linux/restrack.h>
#include "gpiolib.h"
@@ -278,6 +279,8 @@ int gpiochip_add(struct gpio_chip *chip)
if (status)
goto fail;
+ restrack_up(RESTRACK_TYPE_GPIO, chip->of_node, chip);
+
status = gpiochip_export(chip);
if (status)
goto fail;
@@ -313,6 +316,7 @@ void gpiochip_remove(struct gpio_chip *chip)
unsigned long flags;
unsigned id;
+ restrack_down(RESTRACK_TYPE_GPIO, chip->of_node, chip);
acpi_gpiochip_remove(chip);
spin_lock_irqsave(&gpio_lock, flags);
@@ -1770,6 +1774,83 @@ void gpiod_put(struct gpio_desc *desc)
}
EXPORT_SYMBOL_GPL(gpiod_put);
+struct gpiod_restrack_desc {
+ struct gpio_desc **ptr;
+ const char *name;
+ enum gpiod_flags flags;
+ struct of_phandle_args spec;
+ struct restrack_desc desc;
+};
+
+static int gpiod_restrack_init(struct device *dev, struct restrack_desc *desc)
+{
+ struct gpiod_restrack_desc *rd = restrack_desc_to_rd(rd, desc);
+ int ret;
+
+ ret = of_get_gpiod_spec(dev, rd->name, 0, &rd->spec);
+ if (!ret)
+ desc->if_id = rd->spec.np;
+ return ret;
+}
+
+static void gpiod_restrack_destroy(struct device *dev,
+ struct restrack_desc *desc)
+{
+ struct gpiod_restrack_desc *rd = restrack_desc_to_rd(rd, desc);
+
+ of_node_put(desc->if_id);
+ kfree(rd);
+}
+
+static int gpiod_restrack_ifup(struct device *dev, struct restrack_desc *desc,
+ void *data)
+{
+ struct gpiod_restrack_desc *rd = restrack_desc_to_rd(rd, desc);
+
+ *rd->ptr = gpiod_get(dev, rd->name, rd->flags);
+ return PTR_ERR_OR_ZERO(*rd->ptr);
+}
+
+static void gpiod_restrack_ifdown(struct device *dev,
+ struct restrack_desc *desc, void *data)
+{
+ struct gpiod_restrack_desc *rd = restrack_desc_to_rd(rd, desc);
+
+ gpiod_put(*rd->ptr);
+ *rd->ptr = ERR_PTR(-EPROBE_DEFER);
+}
+
+static const struct restrack_ops gpiod_restrack_ops = {
+ .if_type = RESTRACK_TYPE_GPIO,
+ .init = gpiod_restrack_init,
+ .destroy = gpiod_restrack_destroy,
+ .if_up = gpiod_restrack_ifup,
+ .if_down = gpiod_restrack_ifdown,
+};
+
+/**
+ * gpiod_restrack_desc - gpio resource descriptor allocator
+ * @gpiod: pointer to variable which will be set to gpiod handle
+ * @name: name of gpio
+ * @flags: gpiod flags
+ *
+ * The function creates resource description for gpio, which shall be used
+ * by *restrack_register functions.
+ */
+struct restrack_desc *gpiod_restrack_desc(struct gpio_desc **gpiod,
+ const char *con_id, enum gpiod_flags flags)
+{
+ struct gpiod_restrack_desc *rd;
+
+ RESTRACK_DESC_ALLOC(rd, gpiod_restrack_ops, gpiod, con_id);
+ if (!rd)
+ return ERR_PTR(-ENOMEM);
+
+ rd->flags = flags;
+ return &rd->desc;
+}
+EXPORT_SYMBOL_GPL(gpiod_restrack_desc);
+
#ifdef CONFIG_DEBUG_FS
static void gpiolib_dbg_show(struct seq_file *s, struct gpio_chip *chip)
diff --git a/include/linux/gpio/consumer.h b/include/linux/gpio/consumer.h
index 12f146f..55f2e4e 100644
--- a/include/linux/gpio/consumer.h
+++ b/include/linux/gpio/consumer.h
@@ -94,6 +94,10 @@ int gpiod_to_irq(const struct gpio_desc *desc);
struct gpio_desc *gpio_to_desc(unsigned gpio);
int desc_to_gpio(const struct gpio_desc *desc);
+struct restrack_desc;
+struct restrack_desc *gpiod_restrack_desc(struct gpio_desc **gpiod,
+ const char *con_id, enum gpiod_flags flags);
+
#else /* CONFIG_GPIOLIB */
static inline struct gpio_desc *__must_check __gpiod_get(struct device *dev,
diff --git a/include/linux/restrack.h b/include/linux/restrack.h
index 4e4eec6..e1aded0 100644
--- a/include/linux/restrack.h
+++ b/include/linux/restrack.h
@@ -5,6 +5,7 @@
#define RESTRACK_TYPE_DRM_PANEL 1
#define RESTRACK_TYPE_REGULATOR 2
+#define RESTRACK_TYPE_GPIO 3
struct device;
struct restrack_ctx;
--
1.9.1
next prev parent reply other threads:[~2014-12-10 15:52 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 15:48 [RFC 00/15] Resource tracking/allocation framework Andrzej Hajda
2014-12-10 15:48 ` [RFC 01/15] drivers/base: add track framework Andrzej Hajda
2014-12-12 16:36 ` Mark Brown
2014-12-12 23:12 ` AH
2014-12-15 12:55 ` Mark Brown
2014-12-15 14:00 ` Andrzej Hajda
2014-12-10 15:48 ` [RFC 02/15] drivers/base: add restrack framework Andrzej Hajda
2014-12-12 16:52 ` Mark Brown
2014-12-15 8:28 ` Andrzej Hajda
2014-12-15 11:38 ` Mark Brown
2014-12-10 15:48 ` [RFC 03/15] drm/panel: add restrack support Andrzej Hajda
2014-12-10 15:48 ` [RFC 04/15] regulator: " Andrzej Hajda
2014-12-10 16:07 ` Mark Brown
2014-12-11 10:49 ` Andrzej Hajda
2014-12-11 12:58 ` Mark Brown
2014-12-11 13:43 ` Russell King - ARM Linux
2014-12-12 8:22 ` Andrzej Hajda
2014-12-10 15:48 ` [RFC 05/15] gpio: move DT parsing code to separate functions Andrzej Hajda
2015-01-13 6:17 ` Linus Walleij
2014-12-10 15:48 ` Andrzej Hajda [this message]
2014-12-10 15:48 ` [RFC 07/15] clk: add DT parsing function Andrzej Hajda
2015-01-13 19:24 ` Mike Turquette
2014-12-10 15:48 ` [RFC 08/15] clk: add restrack support Andrzej Hajda
2015-01-13 19:25 ` Mike Turquette
2014-12-10 15:48 ` [RFC 09/15] phy: " Andrzej Hajda
2014-12-10 15:48 ` [RFC 10/15] drm/exynos/dsi: simplify hotplug code Andrzej Hajda
2014-12-10 15:48 ` [RFC 11/15] drm/exynos/dsi: convert to restrack API Andrzej Hajda
2014-12-10 15:48 ` [RFC 12/15] drm/exynos/dpi: use common of_graph functions Andrzej Hajda
2014-12-10 15:48 ` [RFC 13/15] drm/exynos/dpi: convert to restrack API Andrzej Hajda
2014-12-10 15:48 ` [RFC 14/15] drm/panel/ld9040: do not power off panel on removal Andrzej Hajda
2014-12-10 15:48 ` [RFC 15/15] drm/panel/ld9040: convert to restrack API Andrzej Hajda
2014-12-10 16:16 ` [RFC 00/15] Resource tracking/allocation framework Russell King - ARM Linux
[not found] ` <CA+tnuKYSDZ0mtzQ_g1QjovJwG01OgPjSXuozEBXQsEZv_2o-=w@mail.gmail.com>
2014-12-10 17:39 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418226513-14105-7-git-send-email-a.hajda@samsung.com \
--to=a.hajda@samsung.com \
--cc=boris.brezillon@free-electrons.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gnurou@gmail.com \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=inki.dae@samsung.com \
--cc=kishon@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=mturquette@linaro.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®