From: Krzysztof Konopko <kris@konagma.com>
To: Larry Finger <Larry.Finger@lwfinger.net>,
Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, kris@konagma.com
Subject: [PATCH] staging: rtl8723au: Fix sparse warnings
Date: Thu, 11 Dec 2014 23:23:29 +0100 [thread overview]
Message-ID: <1418336609-10191-1-git-send-email-kris@konagma.com> (raw)
Some struct fields in wifi.h are meant to be __le16 bu were declared as
unsigned short. This was reported by sparse:
rtw_wlan_util.c:538:24: warning: cast to restricted __le16
rtw_wlan_util.c:1544:29: warning: cast to restricted __le16
rtw_wlan_util.c:1546:25: warning: cast to restricted __le16
This patch changes declared types of the struct fields involved.
Signed-off-by: Krzysztof Konopko <kris@konagma.com>
---
drivers/staging/rtl8723au/include/wifi.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723au/include/wifi.h b/drivers/staging/rtl8723au/include/wifi.h
index fd3da3b..8a2adc5 100644
--- a/drivers/staging/rtl8723au/include/wifi.h
+++ b/drivers/staging/rtl8723au/include/wifi.h
@@ -28,7 +28,7 @@
struct AC_param {
unsigned char ACI_AIFSN;
unsigned char CW;
- unsigned short TXOP_limit;
+ __le16 TXOP_limit;
} __packed;
struct WMM_para_element {
@@ -39,9 +39,9 @@ struct WMM_para_element {
struct ADDBA_request {
unsigned char dialog_token;
- unsigned short BA_para_set;
+ __le16 BA_para_set;
unsigned short BA_timeout_value;
- unsigned short BA_starting_seqctrl;
+ __le16 BA_starting_seqctrl;
} __packed;
--
2.1.3
next reply other threads:[~2014-12-11 22:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 22:23 Krzysztof Konopko [this message]
2014-12-11 23:53 ` Larry Finger
2014-12-12 11:35 ` Krzysztof Konopko
2014-12-12 13:24 ` Johannes Berg
2014-12-12 17:10 ` Jes Sorensen
2014-12-12 17:35 ` Larry Finger
2014-12-12 18:52 ` Jes Sorensen
2014-12-12 22:55 ` Krzysztof Konopko
2014-12-15 15:36 ` Jes Sorensen
2014-12-12 22:50 ` Krzysztof Konopko
2014-12-13 3:18 ` Larry Finger
2014-12-12 12:52 ` Dan Carpenter
2014-12-12 16:43 ` Larry Finger
2014-12-12 22:30 ` Krzysztof Konopko
2014-12-12 17:12 ` Jes Sorensen
2014-12-12 22:34 ` Krzysztof Konopko
2014-12-12 22:58 ` Krzysztof Konopko
2014-12-13 6:43 ` Joe Perches
2014-12-15 15:02 ` Krzysztof Konopko
2014-12-15 15:46 ` Jes Sorensen
2014-12-15 15:39 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418336609-10191-1-git-send-email-kris@konagma.com \
--to=kris@konagma.com \
--cc=Jes.Sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®