From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Joe Perches <joe@perches.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/3] checkpatch: Check for use of disallowed macros
Date: Fri, 12 Dec 2014 11:51:26 +0100 [thread overview]
Message-ID: <1418381488-25123-1-git-send-email-linux@rasmusvillemoes.dk> (raw)
Since fe7c36c7 ("Makefile: Build with -Werror=date-time if the
compiler supports it"), use of __DATE__, __TIME__, __TIMESTAMP__ has
been disallowed. This hasn't prevented a few new users from creeping
in. Make checkpatch complain.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
scripts/checkpatch.pl | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index f0bb6d60c07b..7fafd3b45539 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3008,6 +3008,12 @@ sub process {
$line =~ s@//.*@@;
$opline =~ s@//.*@@;
+
+# Use of __DATE__, __TIME__, __TIMESTAMP__ is not allowed
+ if ($line =~ m/\b__(?:DATE|TIME|TIMESTAMP)__\b/) {
+ ERROR("DATETIME", "Do not use the macros __DATE__, __TIME__ and __TIMESTAMP__\n" . $herecurr)
+ }
+
# EXPORT_SYMBOL should immediately follow the thing it is exporting, consider
# the whole statement.
#print "APW <$lines[$realline_next - 1]>\n";
--
2.1.3
next reply other threads:[~2014-12-12 10:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-12 10:51 Rasmus Villemoes [this message]
2014-12-12 10:51 ` [PATCH 2/3] staging: unisys: remove leftover __DATE__ Rasmus Villemoes
2014-12-12 10:51 ` [PATCH 3/3] ACPICA: Remove use of __DATE__ macro Rasmus Villemoes
2015-01-05 8:47 ` Zheng, Lv
2015-01-05 10:26 ` Rasmus Villemoes
2015-01-06 0:30 ` Zheng, Lv
2015-01-06 19:36 ` [Devel] " David E. Box
2015-01-13 2:33 ` Zheng, Lv
2015-01-13 5:42 ` Zheng, Lv
2014-12-12 11:16 ` [PATCH 1/3] checkpatch: Check for use of disallowed macros Joe Perches
2014-12-18 21:15 ` Rasmus Villemoes
2014-12-18 21:26 ` Joe Perches
2014-12-18 22:17 ` checkpatch: Emit an error when using predefined timestamp macros Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418381488-25123-1-git-send-email-linux@rasmusvillemoes.dk \
--to=linux@rasmusvillemoes.dk \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®