From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752461AbaLOQUp (ORCPT ); Mon, 15 Dec 2014 11:20:45 -0500 Received: from mx02.posteo.de ([89.146.194.165]:32939 "EHLO mx02.posteo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751856AbaLOQTO (ORCPT ); Mon, 15 Dec 2014 11:19:14 -0500 From: Martin Kepplinger To: peterz@infradead.org Cc: mingo@kernel.org, tytso@mit.edu, linux-kernel@vger.kernel.org, Martin Kepplinger Subject: [PATCH 6/6] media: stb0899: use sign_extend8 instead of manual work Date: Mon, 15 Dec 2014 17:18:37 +0100 Message-Id: <1418660317-21750-7-git-send-email-martink@posteo.de> X-Mailer: git-send-email 2.1.3 In-Reply-To: <1418660317-21750-1-git-send-email-martink@posteo.de> References: <1418660317-21750-1-git-send-email-martink@posteo.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Signed-off-by: Martin Kepplinger --- drivers/media/dvb-frontends/stb0899_algo.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/media/dvb-frontends/stb0899_algo.c b/drivers/media/dvb-frontends/stb0899_algo.c index 93596e0..7bbcfde 100644 --- a/drivers/media/dvb-frontends/stb0899_algo.c +++ b/drivers/media/dvb-frontends/stb0899_algo.c @@ -19,6 +19,7 @@ Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. */ +#include #include "stb0899_drv.h" #include "stb0899_priv.h" #include "stb0899_reg.h" @@ -1490,9 +1491,7 @@ enum stb0899_status stb0899_dvbs2_algo(struct stb0899_state *state) /* Store signal parameters */ offsetfreq = STB0899_READ_S2REG(STB0899_S2DEMOD, CRL_FREQ); - /* sign extend 30 bit value before using it in calculations */ - if (offsetfreq & (1 << 29)) - offsetfreq |= -1 << 30; + offsetfreq = sign_extend32(offset_freq, 29); offsetfreq = offsetfreq / ((1 << 30) / 1000); offsetfreq *= (internal->master_clk / 1000000); -- 2.1.3