From: Peter Wu <peter@lekensteyn.nl>
To: Jiri Kosina <jkosina@suse.cz>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Nestor Lopez Casado <nlopezcasad@logitech.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] HID: logitech-{dj,hidpp}: more reliability fixes
Date: Tue, 16 Dec 2014 01:50:13 +0100 [thread overview]
Message-ID: <1418691016-30681-1-git-send-email-peter@lekensteyn.nl> (raw)
Hi Jiri,
Here are more fixes intended for the 3.19 tree after a review. Two bugfixes.
one which was mentioned in a mail with Benjamin ("avoid unintended
fall-through") and a fix to avoid a possible 5 second delay for HID++ 2.0
errors. I haven't encountered a case where the hidpp module generates a HID++
2.0 error though, so maybe that change can go to 3.20 too if you want to keep
the changeset small.
The third (second) patch adds a check to avoid passing a short report. A similar
fix should probably be written for stable kernels (the code was changed in 3.19,
but the length check was already missing in older kernels).
Kind regards,
Peter
Peter Wu (3):
HID: logitech-hidpp: detect HID++ 2.0 errors too
HID: logitech-{dj,hidpp}: check report length
HID: logitech-hidpp: avoid unintended fall-through
drivers/hid/hid-logitech-dj.c | 16 +++++++++++++++-
drivers/hid/hid-logitech-hidpp.c | 30 ++++++++++++++++++++++++------
2 files changed, 39 insertions(+), 7 deletions(-)
--
2.1.3
next reply other threads:[~2014-12-16 0:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 0:50 Peter Wu [this message]
2014-12-16 0:50 ` [PATCH 1/3] HID: logitech-hidpp: detect HID++ 2.0 errors too Peter Wu
2014-12-16 14:33 ` Benjamin Tissoires
2014-12-16 14:52 ` Peter Wu
2014-12-18 17:26 ` Peter Wu
2014-12-18 17:57 ` Benjamin Tissoires
2014-12-17 15:30 ` Benjamin Tissoires
2014-12-19 10:03 ` Jiri Kosina
2014-12-19 10:44 ` Jiri Kosina
2014-12-16 0:50 ` [PATCH 2/3] HID: logitech-{dj,hidpp}: check report length Peter Wu
2014-12-16 14:53 ` Benjamin Tissoires
2014-12-16 15:20 ` Peter Wu
2014-12-16 15:38 ` Benjamin Tissoires
2014-12-16 15:55 ` [PATCH v2 1/3] HID: logitech-dj: " Peter Wu
2014-12-16 15:55 ` [PATCH v2 2/3] HID: logitech-hidpp: check WTP " Peter Wu
2014-12-16 21:56 ` Benjamin Tissoires
2014-12-17 7:53 ` Jiri Kosina
2014-12-16 15:55 ` [PATCH v2 3/3] HID: logitech-hidpp: separate HID++ from WTP processing Peter Wu
2014-12-16 22:00 ` Benjamin Tissoires
2014-12-16 23:23 ` [PATCH " Peter Wu
2014-12-17 7:55 ` Jiri Kosina
2014-12-16 21:55 ` [PATCH v2 1/3] HID: logitech-dj: check report length Benjamin Tissoires
2014-12-17 7:53 ` Jiri Kosina
2014-12-19 10:48 ` [PATCH 2/3] HID: logitech-{dj,hidpp}: " Jiri Kosina
2014-12-16 0:50 ` [PATCH 3/3] HID: logitech-hidpp: avoid unintended fall-through Peter Wu
2014-12-16 14:54 ` Benjamin Tissoires
2014-12-17 15:32 ` Benjamin Tissoires
2014-12-19 10:45 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418691016-30681-1-git-send-email-peter@lekensteyn.nl \
--to=peter@lekensteyn.nl \
--cc=benjamin.tissoires@redhat.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nlopezcasad@logitech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®