From: Dmitry Torokhov <dtor@chromium.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Viresh Kumar <viresh.kumar@linaro.org>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Stefan Wahren <stefan.wahren@i2se.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Nishanth Menon <nm@ti.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/4] PM / OPP: fix warning in of_free_opp_table
Date: Tue, 16 Dec 2014 15:09:37 -0800 [thread overview]
Message-ID: <1418771379-24369-3-git-send-email-dtor@chromium.org> (raw)
In-Reply-To: <1418771379-24369-1-git-send-email-dtor@chromium.org>
Not having OPP defined for a device is not a crime, we should not splat
warning in this case. Also, it seems that we are ready to accept invalid
dev (find_device_opp will return ERR_PTR(-EINVAL) then) so let's not
crash in dev_name() in such case.
Signed-off-by: Dmitry Torokhov <dtor@chromium.org>
---
drivers/base/power/opp.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c
index b78c14d..413c7fe 100644
--- a/drivers/base/power/opp.c
+++ b/drivers/base/power/opp.c
@@ -799,9 +799,15 @@ void of_free_opp_table(struct device *dev)
/* Check for existing list for 'dev' */
dev_opp = find_device_opp(dev);
- if (WARN(IS_ERR(dev_opp), "%s: dev_opp: %ld\n", dev_name(dev),
- PTR_ERR(dev_opp)))
+ if (IS_ERR(dev_opp)) {
+ int error = PTR_ERR(dev_opp);
+ if (error != -ENODEV)
+ WARN(1, "%s: dev_opp: %ld\n",
+ IS_ERR_OR_NULL(dev) ?
+ "Invalid device" : dev_name(dev),
+ error);
return;
+ }
/* Hold our list modification lock here */
mutex_lock(&dev_opp_list_lock);
--
2.2.0.rc0.207.ga3a616c
next prev parent reply other threads:[~2014-12-16 23:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 23:09 [PATCH 0/4] Allow cpufreq-dt to defer probe if OPP table is not ready Dmitry Torokhov
2014-12-16 23:09 ` [PATCH 1/4] PM / OPP: add some lockdep annotations Dmitry Torokhov
2014-12-17 4:10 ` Viresh Kumar
2014-12-24 16:28 ` Nishanth Menon
2014-12-16 23:09 ` Dmitry Torokhov [this message]
2014-12-17 4:28 ` [PATCH 2/4] PM / OPP: fix warning in of_free_opp_table Viresh Kumar
2014-12-24 16:42 ` Nishanth Menon
2014-12-16 23:09 ` [PATCH 3/4] PM / OPP: take RCU lock in dev_pm_opp_get_opp_count Dmitry Torokhov
2014-12-17 4:36 ` Viresh Kumar
2014-12-17 17:28 ` Dmitry Torokhov
2014-12-18 2:11 ` Viresh Kumar
2014-12-17 23:47 ` Paul E. McKenney
2014-12-18 2:11 ` Viresh Kumar
2014-12-24 16:48 ` Nishanth Menon
2014-12-24 17:09 ` Dmitry Torokhov
2014-12-24 17:16 ` Nishanth Menon
2014-12-24 17:31 ` Dmitry Torokhov
2014-12-24 17:37 ` Nishanth Menon
2014-12-24 17:44 ` Dmitry Torokhov
2014-12-24 20:37 ` Nishanth Menon
2014-12-27 20:34 ` Rafael J. Wysocki
2014-12-16 23:09 ` [PATCH 4/4] cpufreq-dt: defer probing if OPP table is not ready Dmitry Torokhov
2014-12-17 4:37 ` Viresh Kumar
2014-12-24 16:58 ` Nishanth Menon
2014-12-17 4:42 ` [PATCH 0/4] Allow cpufreq-dt to defer probe " Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418771379-24369-3-git-send-email-dtor@chromium.org \
--to=dtor@chromium.org \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=paul.gortmaker@windriver.com \
--cc=rjw@rjwysocki.net \
--cc=stefan.wahren@i2se.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®