From: Brian Norris <computersforpeace@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@canonical.com>,
Kevin Cernekee <cernekee@gmail.com>,
Brian Norris <computersforpeace@gmail.com>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH] checkpatch: enable MAINTAINERS warning only for --strict,--subjective
Date: Tue, 16 Dec 2014 23:35:32 -0800 [thread overview]
Message-ID: <1418801732-19141-1-git-send-email-computersforpeace@gmail.com> (raw)
The rule which delivers this warning is very prone to errors:
"added, moved or deleted file(s), does MAINTAINERS need updating?"
so it should not be enabled by default.
The current checkpatch rule doesn't check:
1. whether other patches in the same series update MAINTAINERS
2. whether MAINTAINERS already contains a sufficient entry (e.g., with
an appropriate wildcard pattern)
Given that #1 is impossible to fix and #2 is highly subjective (what's
"appropriate"? is the subsystem maintainer fine with maintaining a new
small driver? or should the driver author be adding himself/herself for
a niche driver?), I'd be just as happy to remove this rule entirely.
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
---
scripts/checkpatch.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index f0bb6d60c07b..7057d1f54947 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2189,7 +2189,7 @@ sub process {
}
# Check for added, moved or deleted files
- if (!$reported_maintainer_file && !$in_commit_log &&
+ if ($check && !$reported_maintainer_file && !$in_commit_log &&
($line =~ /^(?:new|deleted) file mode\s*\d+\s*$/ ||
$line =~ /^rename (?:from|to) [\w\/\.\-]+\s*$/ ||
($line =~ /\{\s*([\w\/\.\-]*)\s*\=\>\s*([\w\/\.\-]*)\s*\}/ &&
--
1.9.1
next reply other threads:[~2014-12-17 7:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 7:35 Brian Norris [this message]
2014-12-17 9:27 ` Joe Perches
2014-12-17 15:53 ` Kevin Cernekee
2014-12-17 17:26 ` Joe Perches
2014-12-18 20:12 ` [PATCH] checkpatch: Fix MAINTAINERS search pattern Derek Chickles
2014-12-18 21:17 ` Joe Perches
2014-12-19 2:34 ` Chickles, Derek
2014-12-19 3:57 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418801732-19141-1-git-send-email-computersforpeace@gmail.com \
--to=computersforpeace@gmail.com \
--cc=apw@canonical.com \
--cc=cernekee@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome