From: Nishanth Menon <nm@ti.com>
To: Viresh Kumar <viresh.kumar@linaro.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: <linux-kernel@vger.kernel.org>, <linux-pm@vger.kernel.org>,
Nishanth Menon <nm@ti.com>
Subject: [PATCH] cpufreq: Stop BUGing the system
Date: Wed, 17 Dec 2014 09:51:35 -0600 [thread overview]
Message-ID: <1418831495-26958-1-git-send-email-nm@ti.com> (raw)
CPUFRreq subsystem is not a system catastrophic failure point.
Failures in these cases DONOT need complete system shutdown with BUG.
just refuse to let cpufreq function should be good enough.
Signed-off-by: Nishanth Menon <nm@ti.com>
---
drivers/cpufreq/cpufreq.c | 17 +++++++++++++----
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index a09a29c..a5aa2fa 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -281,7 +281,10 @@ static inline void adjust_jiffies(unsigned long val, struct cpufreq_freqs *ci)
static void __cpufreq_notify_transition(struct cpufreq_policy *policy,
struct cpufreq_freqs *freqs, unsigned int state)
{
- BUG_ON(irqs_disabled());
+ if (irqs_disabled()) {
+ WARN(1, "IRQs disabled!\n");
+ return;
+ }
if (cpufreq_disabled())
return;
@@ -1253,9 +1256,12 @@ static int __cpufreq_add_dev(struct device *dev, struct subsys_interface *sif)
/*
* Reaching here after boot in a few seconds may not
* mean that system will remain stable at "unknown"
- * frequency for longer duration. Hence, a BUG_ON().
+ * frequency for longer duration. Hence, a WARN().
*/
- BUG_ON(ret);
+ if (ret) {
+ WARN(1, "SYSTEM operating at invalid freq %u", policy->cur);
+ goto err_out_unregister;
+ }
pr_warn("%s: CPU%d: Unlisted initial frequency changed to: %u KHz\n",
__func__, policy->cpu, policy->cur);
}
@@ -2556,7 +2562,10 @@ static int __init cpufreq_core_init(void)
return -ENODEV;
cpufreq_global_kobject = kobject_create();
- BUG_ON(!cpufreq_global_kobject);
+ if (!cpufreq_global_kobject) {
+ WARN(1, "No memory for cpufreq_global_kobject\n");
+ return -ENOMEM;
+ }
return 0;
}
--
1.7.9.5
next reply other threads:[~2014-12-17 15:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 15:51 Nishanth Menon [this message]
2014-12-17 19:16 ` Kevin Hilman
2014-12-18 2:08 ` Viresh Kumar
2014-12-18 14:49 ` Nishanth Menon
2014-12-19 1:41 ` Viresh Kumar
2014-12-19 2:08 ` Rafael J. Wysocki
2014-12-24 15:06 ` Nishanth Menon
2014-12-27 20:37 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418831495-26958-1-git-send-email-nm@ti.com \
--to=nm@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®