From: Lukasz Majewski <l.majewski@samsung.com>
To: Eduardo Valentin <edubezval@gmail.com>,
Kamil Debski <k.debski@samsung.com>,
Jean Delvare <jdelvare@suse.de>,
Guenter Roeck <linux@roeck-us.net>
Cc: lm-sensors@lm-sensors.org,
Linux PM list <linux-pm@vger.kernel.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
devicetree@vger.kernel.org,
Lukasz Majewski <l.majewski@majess.pl>,
Kukjin Kim <kgene.kim@samsung.com>,
linux-kernel@vger.kernel.org,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Lukasz Majewski <l.majewski@samsung.com>
Subject: [PATCH 8/9] hwmon: thermal: Provide 'default-pulse-width' property to setup FAN on boot
Date: Thu, 18 Dec 2014 11:13:10 +0100 [thread overview]
Message-ID: <1418897591-18332-9-git-send-email-l.majewski@samsung.com> (raw)
In-Reply-To: <1418897591-18332-1-git-send-email-l.majewski@samsung.com>
Up till now the PWM fan was enabled by default in the pwm-fan driver.
Now, by defining 'default-pulse-width' device tree property, it is possible
to configure the fan RPM on boot. By specifying value of 0, one can disable it.
Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
---
drivers/hwmon/pwm-fan.c | 34 ++++++++++++++++------------------
1 file changed, 16 insertions(+), 18 deletions(-)
diff --git a/drivers/hwmon/pwm-fan.c b/drivers/hwmon/pwm-fan.c
index 97b77e9..c1cf48b 100644
--- a/drivers/hwmon/pwm-fan.c
+++ b/drivers/hwmon/pwm-fan.c
@@ -34,6 +34,7 @@ struct pwm_fan_ctx {
unsigned int pwm_value;
unsigned int pwm_fan_state;
unsigned int pwm_fan_max_state;
+ unsigned int pwm_fan_default_width;
unsigned int *pwm_fan_cooling_states;
};
@@ -172,8 +173,21 @@ static const struct thermal_cooling_device_ops pwm_fan_cooling_ops = {
int pwm_fan_of_get_cooling_data(struct device *dev, struct pwm_fan_ctx *ctx)
{
struct device_node *np = dev->of_node;
+ int len, num, i, ret;
struct property *pp;
- int len, num, i;
+
+ ret = of_property_read_u32(np, "default-pulse-width",
+ &ctx->pwm_fan_default_width);
+ if (ret) {
+ dev_err(dev, "Property: 'default-pulse-width' not found\n");
+ return -EINVAL;
+ }
+
+ if (ctx->pwm_fan_default_width > MAX_PWM) {
+ dev_err(dev, "'default-pulse-width %d larger than %d\n",
+ ctx->pwm_fan_default_width, MAX_PWM);
+ return -EINVAL;
+ }
pp = of_find_property(np, "cooling-pwm-values", &len);
if (!pp) {
@@ -217,7 +231,6 @@ static int pwm_fan_probe(struct platform_device *pdev)
struct thermal_cooling_device *cdev;
struct pwm_fan_ctx *ctx;
struct device *hwmon;
- int duty_cycle;
int ret;
ctx = devm_kzalloc(&pdev->dev, sizeof(*ctx), GFP_KERNEL);
@@ -237,22 +250,7 @@ static int pwm_fan_probe(struct platform_device *pdev)
if (ret)
return ret;
- /* Set duty cycle to maximum allowed */
- duty_cycle = ctx->pwm->period - 1;
- ctx->pwm_value = MAX_PWM;
-
- ret = pwm_config(ctx->pwm, duty_cycle, ctx->pwm->period);
- if (ret) {
- dev_err(&pdev->dev, "Failed to configure PWM\n");
- return ret;
- }
-
- /* Enbale PWM output */
- ret = pwm_enable(ctx->pwm);
- if (ret) {
- dev_err(&pdev->dev, "Failed to enable PWM\n");
- return ret;
- }
+ __set_pwm(ctx, ctx->pwm_fan_default_width);
hwmon = devm_hwmon_device_register_with_groups(&pdev->dev, "pwmfan",
ctx, pwm_fan_groups);
--
2.0.0.rc2
next prev parent reply other threads:[~2014-12-18 10:15 UTC|newest]
Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-18 10:13 [PATCH 0/9] hwmon: thermal: Odroid U3: Provide support for Odroid U3 fan Lukasz Majewski
2014-12-18 10:13 ` [PATCH 1/9] thermal: Provide stub for thermal_of_cooling_device_register() function Lukasz Majewski
2014-12-18 10:13 ` [PATCH 2/9] hwmon: dts: Doc: Add DTS doc to explain how to use PWM FAN as a cooling device Lukasz Majewski
2014-12-18 10:42 ` Sjoerd Simons
2014-12-19 15:32 ` Lukasz Majewski
2014-12-19 16:02 ` Guenter Roeck
2014-12-19 16:13 ` Lukasz Majewski
2015-01-05 10:50 ` Sjoerd Simons
2015-01-14 13:56 ` Lukasz Majewski
2015-01-15 8:57 ` Sjoerd Simons
2014-12-18 14:27 ` Guenter Roeck
2014-12-19 16:25 ` Lukasz Majewski
2014-12-18 10:13 ` [PATCH 3/9] ARM: dts: Add pwm-fan node to the Odroid-U3 board Lukasz Majewski
2014-12-18 10:13 ` [PATCH 4/9] hwmon: thermal: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3 Lukasz Majewski
2014-12-18 10:13 ` [PATCH 5/9] hwmon: thermal: Extract __set_pwm() function to only modify PWM duty cycle Lukasz Majewski
2014-12-18 10:13 ` [PATCH 6/9] hwmon: thermal: Read PWM FAN configuration from device tree Lukasz Majewski
2014-12-18 10:13 ` [PATCH 7/9] hwmon: thermal: Code for using PWM FAN as a cooling device Lukasz Majewski
2014-12-18 10:13 ` Lukasz Majewski [this message]
2014-12-18 10:13 ` [PATCH 9/9] hwmon: thermal: dts: Disable FAN on boot on the Odroid U3 Lukasz Majewski
2014-12-22 16:27 ` [PATCH v2 0/8] hwmon: thermal: Odroid U3: Provide support for Odroid U3 fan Lukasz Majewski
2014-12-22 16:27 ` [PATCH v2 1/8] thermal: Provide stub for thermal_of_cooling_device_register() function Lukasz Majewski
2015-01-02 18:54 ` Eduardo Valentin
2015-01-02 19:03 ` Eduardo Valentin
2015-01-14 15:01 ` Lukasz Majewski
2015-01-14 18:32 ` Eduardo Valentin
2015-01-15 8:43 ` Lukasz Majewski
2014-12-22 16:27 ` [PATCH v2 2/8] thermal: Provide stub for thermal_cdev_update() function Lukasz Majewski
2015-01-02 18:40 ` Eduardo Valentin
2015-01-14 15:07 ` Lukasz Majewski
2015-01-14 18:28 ` Eduardo Valentin
2014-12-22 16:27 ` [PATCH v2 3/8] hwmon: dts: Doc: Add DTS doc to explain how to use PWM FAN as a cooling device Lukasz Majewski
2015-01-02 18:51 ` Eduardo Valentin
2014-12-22 16:27 ` [PATCH v2 4/8] ARM: dts: Add pwm-fan node to the Odroid-U3 board Lukasz Majewski
2014-12-22 16:27 ` [PATCH v2 5/8] hwmon: thermal: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3 Lukasz Majewski
2015-01-02 18:52 ` Eduardo Valentin
2014-12-22 16:27 ` [PATCH v2 6/8] hwmon: thermal: Extract __set_pwm() function to only modify PWM duty cycle Lukasz Majewski
2014-12-29 12:52 ` Guenter Roeck
2014-12-22 16:27 ` [PATCH v2 7/8] hwmon: thermal: Read PWM FAN configuration from device tree Lukasz Majewski
2014-12-29 12:50 ` Guenter Roeck
2014-12-22 16:27 ` [PATCH v2 8/8] hwmon: thermal: Code for using PWM FAN as a cooling device Lukasz Majewski
2015-02-06 16:59 ` [PATCH v3 0/8] hwmon: thermal: Odroid U3: Provide support for Odroid U3 fan Lukasz Majewski
2015-02-06 16:59 ` [PATCH v3 1/8] thermal: Provide stub for thermal_of_cooling_device_register() function Lukasz Majewski
2015-02-06 16:59 ` [PATCH v3 2/8] thermal: Provide stub for thermal_cdev_update() function Lukasz Majewski
2015-02-06 16:59 ` [PATCH v3 3/8] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device Lukasz Majewski
2015-02-06 16:59 ` [PATCH v3 4/8] ARM: dts: Add pwm-fan node to the Odroid-U3 board Lukasz Majewski
2015-02-06 16:59 ` [PATCH v3 5/8] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3 Lukasz Majewski
2015-02-06 16:59 ` [PATCH v3 6/8] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty cycle Lukasz Majewski
2015-02-06 18:27 ` Guenter Roeck
2015-02-08 20:52 ` Lukasz Majewski
2015-02-06 16:59 ` [PATCH v3 7/8] hwmon: pwm-fan: Read PWM FAN configuration from device tree Lukasz Majewski
2015-02-06 18:36 ` Guenter Roeck
2015-02-08 21:36 ` Lukasz Majewski
2015-02-09 4:40 ` Guenter Roeck
2015-02-06 16:59 ` [PATCH v3 8/8] hwmon: pwm-fan: Code for using PWM FAN as a cooling device Lukasz Majewski
2015-02-18 10:07 ` [PATCH v4 0/8] hwmon: thermal: Odroid U3: Provide support for Odroid U3 fan Lukasz Majewski
2015-02-18 10:07 ` [PATCH v4 1/8] thermal: Provide stub for thermal_of_cooling_device_register() function Lukasz Majewski
2015-02-24 19:21 ` Eduardo Valentin
2015-02-25 12:26 ` Lukasz Majewski
2015-02-18 10:07 ` [PATCH v4 2/8] thermal: Provide stub for thermal_cdev_update() function Lukasz Majewski
2015-02-24 19:21 ` Eduardo Valentin
2015-02-18 10:07 ` [PATCH v4 3/8] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device Lukasz Majewski
2015-02-24 19:25 ` Eduardo Valentin
2015-02-18 10:07 ` [PATCH v4 4/8] ARM: dts: Add pwm-fan node to the Odroid-U3 board Lukasz Majewski
2015-02-18 13:16 ` Andreas Färber
2015-02-18 10:07 ` [PATCH v4 5/8] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3 Lukasz Majewski
2015-02-24 19:37 ` Eduardo Valentin
2015-02-25 13:28 ` Lukasz Majewski
2015-02-25 18:30 ` Eduardo Valentin
2015-02-18 10:07 ` [PATCH v4 6/8] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty cycle Lukasz Majewski
2015-02-18 10:07 ` [PATCH v4 7/8] hwmon: pwm-fan: Read PWM FAN configuration from device tree Lukasz Majewski
2015-02-21 0:26 ` Guenter Roeck
2015-02-23 16:13 ` Lukasz Majewski
2015-02-23 16:23 ` Guenter Roeck
2015-02-23 16:51 ` Lukasz Majewski
2015-02-23 16:59 ` Guenter Roeck
2015-02-18 10:07 ` [PATCH v4 8/8] hwmon: pwm-fan: Code for using PWM FAN as a cooling device Lukasz Majewski
2015-02-25 15:34 ` [PATCH v5 0/6] hwmon: thermal: Odroid U3: Provide support for Odroid U3 fan Lukasz Majewski
2015-02-25 15:34 ` [PATCH v5 1/6] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device Lukasz Majewski
2015-02-25 19:11 ` Eduardo Valentin
2015-02-25 19:13 ` Eduardo Valentin
2015-02-25 15:34 ` [PATCH v5 2/6] ARM: dts: Add pwm-fan node to the Odroid-U3 board Lukasz Majewski
2015-02-25 15:34 ` [PATCH v5 3/6] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3 Lukasz Majewski
2015-02-25 18:49 ` Eduardo Valentin
2015-02-25 15:34 ` [PATCH v5 4/6] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty cycle Lukasz Majewski
2015-02-25 15:34 ` [PATCH v5 5/6] hwmon: pwm-fan: Read PWM FAN configuration from device tree Lukasz Majewski
2015-02-25 15:34 ` [PATCH v5 6/6] hwmon: pwm-fan: Code for using PWM FAN as a cooling device Lukasz Majewski
2015-02-25 18:24 ` Eduardo Valentin
2015-02-25 17:18 ` [PATCH v5 0/6] hwmon: thermal: Odroid U3: Provide support for Odroid U3 fan Guenter Roeck
2015-02-25 18:29 ` Eduardo Valentin
2015-02-25 18:42 ` Guenter Roeck
2015-02-26 13:59 ` [PATCH v6 " Lukasz Majewski
2015-02-26 13:59 ` [PATCH v6 1/6] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device Lukasz Majewski
2015-02-26 13:59 ` [PATCH v6 2/6] ARM: dts: Add pwm-fan node to the Odroid-U3 board Lukasz Majewski
2015-02-26 13:59 ` [PATCH v6 3/6] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3 Lukasz Majewski
2015-02-26 13:59 ` [PATCH v6 4/6] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty cycle Lukasz Majewski
2015-02-26 13:59 ` [PATCH v6 5/6] hwmon: pwm-fan: Read PWM FAN configuration from device tree Lukasz Majewski
2015-02-26 13:59 ` [PATCH v6 6/6] hwmon: pwm-fan: Code for using PWM FAN as a cooling device Lukasz Majewski
2015-02-26 14:12 ` Guenter Roeck
2015-02-26 14:40 ` Lukasz Majewski
2015-03-04 12:03 ` [PATCH RESEND RESEND v6 0/6] hwmon: thermal: Odroid U3: Provide support for Odroid U3 fan Lukasz Majewski
2015-03-04 12:03 ` [PATCH RESEND v6 1/6] Documentation: dts: Documentation entry to explain how to use PWM FAN as a cooling device Lukasz Majewski
2015-03-04 12:03 ` [PATCH RESEND v6 2/6] ARM: dts: Add pwm-fan node to the Odroid-U3 board Lukasz Majewski
2015-03-04 12:03 ` [PATCH RESEND v6 3/6] ARM: dts: Add properties to use pwm-fan device as a cooling device in Odroid U3 Lukasz Majewski
2015-03-04 12:03 ` [PATCH RESEND v6 4/6] hwmon: pwm-fan: Extract __set_pwm() function to only modify PWM duty cycle Lukasz Majewski
2015-03-04 12:03 ` [PATCH RESEND v6 5/6] hwmon: pwm-fan: Read PWM FAN configuration from device tree Lukasz Majewski
2015-03-04 12:03 ` [PATCH RESEND v6 6/6] hwmon: pwm-fan: Code for using PWM FAN as a cooling device Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418897591-18332-9-git-send-email-l.majewski@samsung.com \
--to=l.majewski@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=jdelvare@suse.de \
--cc=k.debski@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=l.majewski@majess.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®