From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752450AbaLRNkB (ORCPT ); Thu, 18 Dec 2014 08:40:01 -0500 Received: from metis.ext.pengutronix.de ([92.198.50.35]:60354 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751705AbaLRNjs (ORCPT ); Thu, 18 Dec 2014 08:39:48 -0500 Message-ID: <1418909978.2236.0.camel@pengutronix.de> Subject: Re: Weird/Unneeded call to msleep in exynos_mipi_dsi_wr_data in exynos_mipi_dsi_common.c From: Lucas Stach To: nick Cc: Krzysztof =?UTF-8?Q?Koz=C5=82owski?= , inki.dae@samsung.com, linux-fbdev@vger.kernel.org, linux-samsung-soc@vger.kernel.org, dh09.lee@samsung.com, linux-kernel@vger.kernel.org, kyungmin.park@samsung.com, tomi.valkeinen@ti.com, kgene@kernel.org, plagnioj@jcrosoft.com, linux-arm-kernel@lists.infradead.org Date: Thu, 18 Dec 2014 14:39:38 +0100 In-Reply-To: <5492D80E.3010906@gmail.com> References: <54920A54.2060608@gmail.com> <5492ABE7.1060900@samsung.com> <5492D80E.3010906@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.6-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:fa0f:41ff:fe58:4010 X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Donnerstag, den 18.12.2014, 08:35 -0500 schrieb nick: > Krzysztof, > If we look at the code for this function, it already is handling the data correctly. In addition the locks > seem to be better protection then msleep. Further more is no reason for this delay as we are neither resetting > the hardware or waiting for the hardware here so why is it needed? I don't have Exynos based hardware lying > around through to test it. If you can't test it, don't touch it. It's that simple. Regards, Lucas -- Pengutronix e.K. | Lucas Stach | Industrial Linux Solutions | http://www.pengutronix.de/ |