mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Kyle McMartin <kyle@redhat.com>
Cc: linux-kernel@vger.kernel.org, agrover@redhat.com,
	jbastian@redhat.com, target-devel <target-devel@vger.kernel.org>
Subject: Re: [PATCH] uapi/linux/target_core_user.h: fix headers_install.sh badness
Date: Thu, 18 Dec 2014 17:19:58 -0800	[thread overview]
Message-ID: <1418951998.4830.7.camel@haakon3.risingtidesystems.com> (raw)
In-Reply-To: <20141218175714.GF5157@redacted.bos.redhat.com>

Hi Kyle,

On Thu, 2014-12-18 at 12:57 -0500, Kyle McMartin wrote:
> scripts/headers_install.sh will transform __packed to
> __attribute__((packed)), so the #ifndef is not necessary.
> (and, in fact, it's problematic, because we'll end up with the header
>  containing:
> #ifndef __attribute__((packed))
> #define __attribu...
> and so forth.)
> 
> Cc: stable@vger.kernel.org # 3.18
> Signed-off-by: Kyle McMartin <kyle@redhat.com>
> 
> ---
> cc-ing stable@ so this headers fix gets picked up by distros.
> 
> --- a/include/uapi/linux/target_core_user.h
> +++ b/include/uapi/linux/target_core_user.h
> @@ -6,10 +6,6 @@
>  #include <linux/types.h>
>  #include <linux/uio.h>
>  
> -#ifndef __packed
> -#define __packed                        __attribute__((packed))
> -#endif
> -
>  #define TCMU_VERSION "1.0"
>  
>  /*

Applied to target-pending/for-next.

Thanks!

--nab



      parent reply	other threads:[~2014-12-19  1:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-18 17:57 Kyle McMartin
2014-12-18 18:02 ` Andy Grover
2014-12-19  1:19 ` Nicholas A. Bellinger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1418951998.4830.7.camel@haakon3.risingtidesystems.com \
    --to=nab@linux-iscsi.org \
    --cc=agrover@redhat.com \
    --cc=jbastian@redhat.com \
    --cc=kyle@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®