mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Jaeger <cj@linux.com>
To: apw@canonical.com, joe@perches.com
Cc: linux-kernel@vger.kernel.org, dborkman@redhat.com,
	pebolle@tiscali.nl, Christoph Jaeger <cj@linux.com>
Subject: [PATCH] checkpatch: add check for keyword 'boolean' in Kconfig definitions
Date: Sat, 20 Dec 2014 15:40:36 -0500	[thread overview]
Message-ID: <1419108036-11536-1-git-send-email-cj@linux.com> (raw)

Discourage the use of keyword 'boolean' for type definition attributes of
config options as support for it will be dropped later on.

Reference: http://lkml.kernel.org/r/cover.1418003065.git.cj@linux.com
Suggested-by: Daniel Borkmann <dborkman@redhat.com>
Signed-off-by: Christoph Jaeger <cj@linux.com>
---
 scripts/checkpatch.pl | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index f0bb6d6..cae974e 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2355,6 +2355,13 @@ sub process {
 			     "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n");
 		}
 
+# discourage the use of boolean for type definition attributes of Kconfig options
+		if ($realfile =~ /Kconfig/ &&
+		    $line =~ /^\+\s*\bboolean\b/) {
+			WARN("CONFIG_TYPE_BOOLEAN",
+			     "Use of boolean is deprecated, please use bool instead.\n" . $herecurr);
+		}
+
 		if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) &&
 		    ($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) {
 			my $flag = $1;
-- 
2.1.0


             reply	other threads:[~2014-12-20 20:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-20 20:40 Christoph Jaeger [this message]
2014-12-20 20:49 ` Joe Perches
2015-01-05 23:16 ` Paul Bolle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1419108036-11536-1-git-send-email-cj@linux.com \
    --to=cj@linux.com \
    --cc=apw@canonical.com \
    --cc=dborkman@redhat.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pebolle@tiscali.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome