mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Oded Gabbay <oded.gabbay@amd.com>
To: Alexander Deucher <Alexander.Deucher@amd.com>
Cc: <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
	"John Bridgman" <John.Bridgman@amd.com>,
	Dana Elifaz <Dana.Elifaz@amd.com>,
	"Huang Ying" <ying.huang@intel.com>, LKP ML <lkp@01.org>
Subject: [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel
Date: Mon, 22 Dec 2014 13:11:13 +0200	[thread overview]
Message-ID: <1419246673-7222-1-git-send-email-oded.gabbay@amd.com> (raw)

amdkfd driver can be compiled only in 64-bit kernel. Therefore, there is no
point in trying to initialize amdkfd in 32-bit kernel.

In addition, in case of specific configuration of 32-bit kernel, no modules and
random kernel base, the symbol_request function doesn't work as expected - It
doesn't return NULL if the symbol doesn't exists. That makes the kernel panic.
Therefore, the as amdkfd doesn't compile in 32-bit kernel, the best way is just
to return false immediately.

Signed-off-by: Oded Gabbay <oded.gabbay@amd.com>
---
 drivers/gpu/drm/radeon/radeon_kfd.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/radeon/radeon_kfd.c b/drivers/gpu/drm/radeon/radeon_kfd.c
index 242fd8b..cb77e5c 100644
--- a/drivers/gpu/drm/radeon/radeon_kfd.c
+++ b/drivers/gpu/drm/radeon/radeon_kfd.c
@@ -101,6 +101,7 @@ static const struct kgd2kfd_calls *kgd2kfd;
 
 bool radeon_kfd_init(void)
 {
+#ifdef CONFIG_X86_64
 	bool (*kgd2kfd_init_p)(unsigned, const struct kfd2kgd_calls*,
 				const struct kgd2kfd_calls**);
 
@@ -117,6 +118,9 @@ bool radeon_kfd_init(void)
 	}
 
 	return true;
+#else
+	return false;
+#endif
 }
 
 void radeon_kfd_fini(void)
-- 
1.9.1


             reply	other threads:[~2014-12-22 11:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-22 11:11 Oded Gabbay [this message]
2014-12-22 16:58 ` Alex Deucher
2014-12-22 18:49   ` [LKP] " Andi Kleen
2014-12-22 19:00     ` Andi Kleen
2014-12-22 19:18       ` Oded Gabbay
2014-12-23 23:01         ` Rusty Russell
2014-12-24  9:22           ` Oded Gabbay
2015-01-05  4:28             ` Rusty Russell
2015-01-06 20:14               ` Kees Cook
2015-01-06 22:58                 ` Rusty Russell
2015-01-11 11:57                   ` Oded Gabbay
2015-01-13 17:15                   ` Kees Cook
2015-01-16  0:27               ` Kees Cook
2015-01-16 11:27                 ` Oded Gabbay
2015-01-23  4:10                 ` Rusty Russell
2014-12-25 12:31         ` Christian König
2014-12-28  9:05           ` Oded Gabbay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1419246673-7222-1-git-send-email-oded.gabbay@amd.com \
    --to=oded.gabbay@amd.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=Dana.Elifaz@amd.com \
    --cc=John.Bridgman@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@01.org \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome