mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jianqun Xu <jay.xu@rock-chips.com>
To: lgirdwood@gmail.com, heiko@sntech.de, broonie@kernel.org,
	perex@perex.cz, tiwai@suse.de, sonnyrao@chromium.org
Cc: linux-arm-kernel@lists.infradead.org,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, Jianqun Xu <jay.xu@rock-chips.com>
Subject: [PATCH 2/2] ASoC: rockchip: i2s: set TDL and RDL to 16 bits
Date: Tue, 23 Dec 2014 17:08:29 +0800	[thread overview]
Message-ID: <1419325709-15374-3-git-send-email-jay.xu@rock-chips.com> (raw)
In-Reply-To: <1419325709-15374-1-git-send-email-jay.xu@rock-chips.com>

Set Transmit Data Level(TDL) and Receive Data Level(RDL) to 16 bits.
Without this setting, the TDL is default to be 0x00 (means 1 bit),
and the RDL is default to be 0x1f (means 16 bits).

This patch is helpful to fix pop sound, tested on rk3288 board.

Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
---
 sound/soc/rockchip/rockchip_i2s.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c
index c74ba37..1cd7efc 100644
--- a/sound/soc/rockchip/rockchip_i2s.c
+++ b/sound/soc/rockchip/rockchip_i2s.c
@@ -247,6 +247,10 @@ static int rockchip_i2s_hw_params(struct snd_pcm_substream *substream,
 
 	regmap_update_bits(i2s->regmap, I2S_TXCR, I2S_TXCR_VDW_MASK, val);
 	regmap_update_bits(i2s->regmap, I2S_RXCR, I2S_RXCR_VDW_MASK, val);
+	regmap_update_bits(i2s->regmap, I2S_DMACR, I2S_DMACR_TDL_MASK,
+			   I2S_DMACR_TDL(16));
+	regmap_update_bits(i2s->regmap, I2S_DMACR, I2S_DMACR_RDL_MASK,
+			   I2S_DMACR_RDL(16));
 
 	return 0;
 }
-- 
1.9.1



  parent reply	other threads:[~2014-12-23  9:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-23  9:08 [PATCH 0/2] ASoC: rockchip: i2s: fix " Jianqun Xu
2014-12-23  9:08 ` [PATCH 1/2] ASoC: rockchip: i2s: fix error defination of transmit data level Jianqun Xu
2014-12-23  9:08 ` Jianqun Xu [this message]
2014-12-23 23:06   ` [alsa-devel] [PATCH 2/2] ASoC: rockchip: i2s: set TDL and RDL to 16 bits Dylan Reid
2014-12-24  0:36     ` Jianqun
2014-12-24  9:36 ` [PATCH v2 0/3] ASoC: rockchip: i2s: fix watermark to 16 and maxburst to 4 Jianqun Xu
2014-12-24  9:37   ` [PATCH v2 1/3] ASoC: rockchip: i2s: fix error defination of transmit data level Jianqun Xu
2014-12-24  9:37   ` [PATCH v2 2/3] ASoC: rockchip: i2s: set TDL and RDL to 16 samples Jianqun Xu
2014-12-24  9:37   ` [PATCH v2 3/3] ASoC: rockchip: i2s: fix maxburst of dma data to 4 Jianqun Xu
2014-12-24 12:43   ` [PATCH v2 0/3] ASoC: rockchip: i2s: fix watermark to 16 and maxburst " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1419325709-15374-3-git-send-email-jay.xu@rock-chips.com \
    --to=jay.xu@rock-chips.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=sonnyrao@chromium.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®