From: Jonathan Corbet <corbet@lwn.net>
To: linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@infradead.org>, Jonathan Corbet <corbet@lwn.net>
Subject: [PATCH 4/7] Docs: SubmittingPatches: update follow-through instructions
Date: Tue, 23 Dec 2014 09:32:04 -0700 [thread overview]
Message-ID: <1419352327-4517-5-git-send-email-corbet@lwn.net> (raw)
In-Reply-To: <1419352327-4517-1-git-send-email-corbet@lwn.net>
SubmittingPatches was written in the "keep sending to Linus until something
shows up in a release" era. Given that we don't do things that way anymore
and the system is far less lossy, update this information and add some
hints on responding to reviewer comments.
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
---
Documentation/SubmittingPatches | 50 ++++++++++++++++++-----------------------
1 file changed, 22 insertions(+), 28 deletions(-)
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index e169c6ca5243..a8308401a048 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -354,40 +354,34 @@ server, and provide instead a URL (link) pointing to your patch.
-8) Name your kernel version.
-
-It is important to note, either in the subject line or in the patch
-description, the kernel version to which this patch applies.
-
-If the patch does not apply cleanly to the latest kernel version,
-Linus will not apply it.
-
-
+8) Respond to review comments.
+------------------------------
-9) Don't get discouraged. Re-submit.
+Your patch will almost certainly get comments from reviewers on ways in
+which the patch can be improved. You must respond to those comments;
+ignoring reviewers is a good way to get ignored in return. Review comments
+or questions that do not lead to a code change should almost certainly
+bring about a comment or changelog entry so that the next reviewer better
+understands what is going on.
-After you have submitted your change, be patient and wait. If Linus
-likes your change and applies it, it will appear in the next version
-of the kernel that he releases.
+Be sure to tell the reviewers what changes you are making and to thank them
+for their time. Code review is a tiring and time-consuming process, and
+reviewers sometimes get grumpy. Even in that case, though, respond
+politely and address the problems they have pointed out.
-However, if your change doesn't appear in the next version of the
-kernel, there could be any number of reasons. It's YOUR job to
-narrow down those reasons, correct what was wrong, and submit your
-updated change.
-It is quite common for Linus to "drop" your patch without comment.
-That's the nature of the system. If he drops your patch, it could be
-due to
-* Your patch did not apply cleanly to the latest kernel version.
-* Your patch was not sufficiently discussed on linux-kernel.
-* A style issue (see section 2).
-* An e-mail formatting issue (re-read this section).
-* A technical problem with your change.
-* He gets tons of e-mail, and yours got lost in the shuffle.
-* You are being annoying.
+9) Don't get discouraged - or impatient.
+----------------------------------------
-When in doubt, solicit comments on linux-kernel mailing list.
+After you have submitted your change, be patient and wait. Reviewers are
+busy people and may not get to your patch right away.
+Once upon a time, patches used to disappear into the void without comment,
+but the development process works more smoothly than that now. You should
+receive comments within a week or so; if that does not happen, make sure
+that you have sent your patches to the right place. Wait for a minimum of
+one week before resubmitting or pinging reviewers - possibly longer during
+busy times like merge windows.
10) Include PATCH in the subject
--
2.1.0
next prev parent reply other threads:[~2014-12-23 16:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-23 16:32 [PATCH v2] Docs: Modernize SubmittingPatches Jonathan Corbet
2014-12-23 16:32 ` [PATCH 1/7] Docs: Remove "tips and tricks" from SubmittingPatches Jonathan Corbet
2014-12-23 16:32 ` [PATCH 2/7] Docs: Bring SubmittingPatches more into the git era Jonathan Corbet
2016-03-09 9:45 ` David Woodhouse
2016-03-09 11:44 ` Laszlo Ersek
2016-03-09 14:13 ` Jonathan Corbet
2016-03-09 14:04 ` Jonathan Corbet
2016-03-09 14:27 ` David Woodhouse
2014-12-23 16:32 ` [PATCH 3/7] Docs: Update recipient information in SubmittingPatches Jonathan Corbet
2014-12-23 16:32 ` Jonathan Corbet [this message]
2014-12-23 16:32 ` [PATCH 5/7] Docs: SubmittingPatches: miscellaneous cleanups Jonathan Corbet
2014-12-23 16:32 ` [PATCH 6/7] Docs: Mention device tree binding info Jonathan Corbet
2014-12-23 16:32 ` [PATCH 7/7] Docs: SubmittingPatches: mention using pull requests as a cover letter Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1419352327-4517-5-git-send-email-corbet@lwn.net \
--to=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®