From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752427AbaLXHRb (ORCPT ); Wed, 24 Dec 2014 02:17:31 -0500 Received: from LGEMRELSE6Q.lge.com ([156.147.1.121]:40318 "EHLO lgemrelse6q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752204AbaLXHPn (ORCPT ); Wed, 24 Dec 2014 02:15:43 -0500 X-Original-SENDERIP: 10.177.222.235 X-Original-MAILFROM: namhyung@kernel.org From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern , Stephane Eranian , Adrian Hunter , Andi Kleen , Frederic Weisbecker Subject: [PATCH 34/37] perf tools: Convert lseek + read to pread Date: Wed, 24 Dec 2014 16:15:30 +0900 Message-Id: <1419405333-27952-35-git-send-email-namhyung@kernel.org> X-Mailer: git-send-email 2.1.3 In-Reply-To: <1419405333-27952-1-git-send-email-namhyung@kernel.org> References: <1419405333-27952-1-git-send-email-namhyung@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When dso_cache__read() is called, it reads data from the given offset using lseek + normal read syscall. It can be combined to a single pread syscall. Signed-off-by: Namhyung Kim --- tools/perf/util/dso.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c index d8ee1fd826e7..95c8d5a2b934 100644 --- a/tools/perf/util/dso.c +++ b/tools/perf/util/dso.c @@ -593,10 +593,7 @@ dso_cache__read(struct dso *dso, struct machine *machine, } } - if (-1 == lseek(dso->data.fd, cache_offset, SEEK_SET)) - goto err_unlock; - - ret = read(dso->data.fd, cache->data, DSO__DATA_CACHE_SIZE); + ret = pread(dso->data.fd, cache->data, DSO__DATA_CACHE_SIZE, cache_offset); if (ret <= 0) goto err_unlock; -- 2.1.3