mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeremiah Mahler <jmmahler@gmail.com>
To: Oleg Drokin <oleg.drokin@intel.com>
Cc: Andreas Dilger <andreas.dilger@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Peng Tao <bergwolf@gmail.com>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	Greg Donald <gdonald@gmail.com>,
	Anton Saraev <antonysaraev@gmail.com>,
	Vitaly Osipov <vitaly.osipov@gmail.com>,
	Joe Perches <joe@perches.com>,
	HPDD-discuss@ml01.01.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org,
	Jeremiah Mahler <jmmahler@gmail.com>
Subject: [PATCH 3/5] staging: lustre: selftest: fix sfw_deactivate_session context imbalance
Date: Sat, 27 Dec 2014 12:46:48 -0800	[thread overview]
Message-ID: <1419713210-8198-4-git-send-email-jmmahler@gmail.com> (raw)
In-Reply-To: <1419713210-8198-1-git-send-email-jmmahler@gmail.com>

Fix the sparse warning about a context imbalance in the
sfw_deactivate_session function by telling sparse that it
should expect the lock to be held on entry and held on exit.

  drivers/staging/lustre/lnet/selftest/framework.c:210:9: warning: context imbalance in 'sfw_deactivate_session' - unexpected unlock

Signed-off-by: Jeremiah Mahler <jmmahler@gmail.com>
---
 drivers/staging/lustre/lnet/selftest/framework.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/lustre/lnet/selftest/framework.c b/drivers/staging/lustre/lnet/selftest/framework.c
index 56b4ef4..5709148 100644
--- a/drivers/staging/lustre/lnet/selftest/framework.c
+++ b/drivers/staging/lustre/lnet/selftest/framework.c
@@ -194,9 +194,9 @@ sfw_del_session_timer (void)
 	return EBUSY; /* racing with sfw_session_expired() */
 }
 
-/* called with sfw_data.fw_lock held */
 static void
 sfw_deactivate_session (void)
+	__must_hold(&sfw_data.fw_lock)
 {
 	sfw_session_t *sn = sfw_data.fw_session;
 	int	    nactive = 0;
-- 
2.1.4


  parent reply	other threads:[~2014-12-27 20:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-27 20:46 [PATCH 0/5] staging: lustre: selftest: fix various sparse warnings Jeremiah Mahler
2014-12-27 20:46 ` [PATCH 1/5] staging: lustre: selftest: fix "not declared" by declaring in header Jeremiah Mahler
2014-12-27 20:46 ` [PATCH 2/5] staging: lustre: selftest: fix "not declared" by declaring static Jeremiah Mahler
2014-12-27 20:46 ` Jeremiah Mahler [this message]
2014-12-27 20:46 ` [PATCH 4/5] staging: lustre: selftest: fix _post_buffer context imbalance Jeremiah Mahler
2014-12-27 20:46 ` [PATCH 5/5] staging: lustre: selftest: fix _recycle_buffer " Jeremiah Mahler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1419713210-8198-4-git-send-email-jmmahler@gmail.com \
    --to=jmmahler@gmail.com \
    --cc=HPDD-discuss@ml01.01.org \
    --cc=andreas.dilger@intel.com \
    --cc=antonysaraev@gmail.com \
    --cc=bergwolf@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gdonald@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg.drokin@intel.com \
    --cc=peterz@infradead.org \
    --cc=vitaly.osipov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®