From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v1 2/4] hexdump: fix ascii column for the tail of a dump
Date: Mon, 29 Dec 2014 13:50:52 +0200 [thread overview]
Message-ID: <1419853854-5602-3-git-send-email-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <1419853854-5602-1-git-send-email-andriy.shevchenko@linux.intel.com>
In current implementation we have floating ascii column in the tail of the
dump.
For example, for row size equal to 16 the ascii column as in following table
group size \ length 8 12 16
1 50 50 50
2 22 32 42
4 20 29 38
8 19 - 36
This patch makes it the same independently of amount of bytes dumped.
The change is safe since all current users, which use ASCII part of the dump,
rely on the group size equal to 1. The patch doesn't change behaviour for such
group size (see the table above).
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
lib/hexdump.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/hexdump.c b/lib/hexdump.c
index 270773b..a61cb6b 100644
--- a/lib/hexdump.c
+++ b/lib/hexdump.c
@@ -126,7 +126,7 @@ void hex_dump_to_buffer(const void *buf, size_t len, int rowsize,
lx += scnprintf(linebuf + lx, linebuflen - lx,
"%s%16.16llx", j ? " " : "",
(unsigned long long)*(ptr8 + j));
- ascii_column = 17 * ngroups + 2;
+ ascii_column = rowsize * 2 + rowsize / 8 + 2;
break;
}
@@ -137,7 +137,7 @@ void hex_dump_to_buffer(const void *buf, size_t len, int rowsize,
for (j = 0; j < ngroups; j++)
lx += scnprintf(linebuf + lx, linebuflen - lx,
"%s%8.8x", j ? " " : "", *(ptr4 + j));
- ascii_column = 9 * ngroups + 2;
+ ascii_column = rowsize * 2 + rowsize / 4 + 2;
break;
}
@@ -148,7 +148,7 @@ void hex_dump_to_buffer(const void *buf, size_t len, int rowsize,
for (j = 0; j < ngroups; j++)
lx += scnprintf(linebuf + lx, linebuflen - lx,
"%s%4.4x", j ? " " : "", *(ptr2 + j));
- ascii_column = 5 * ngroups + 2;
+ ascii_column = rowsize * 2 + rowsize / 2 + 2;
break;
}
--
2.1.3
next prev parent reply other threads:[~2014-12-29 11:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-29 11:50 [PATCH v1 0/4] hexdump: amend the hex_dump_to_buffer() Andy Shevchenko
2014-12-29 11:50 ` [PATCH v1 1/4] hexdump: introduce test suite Andy Shevchenko
2015-01-12 15:08 ` Paul Gortmaker
2014-12-29 11:50 ` Andy Shevchenko [this message]
2014-12-29 11:50 ` [PATCH v1 3/4] hexdump: do few calculations ahead Andy Shevchenko
2014-12-29 11:50 ` [PATCH v1 4/4] hexdump: makes it return amount of bytes placed in buffer Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1419853854-5602-3-git-send-email-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome