From: Kumar Gala <galak@kernel.crashing.org>
To: avorontsov@ru.mvista.com
Cc: Dave Jones <davej@redhat.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: fix fsl_upm nand driver modular build
Date: Mon, 13 Oct 2008 11:48:38 -0500 [thread overview]
Message-ID: <141BB874-FDA4-4107-BEF6-15B84023E44B@kernel.crashing.org> (raw)
In-Reply-To: <20081009003259.GA8373@oksana.dev.rtsoft.ru>
On Oct 8, 2008, at 7:32 PM, Anton Vorontsov wrote:
> The fsl_upm nand driver fails to build because fsl_lbc_lock isn't
> exported, the lock is needed by the inlined fsl_upm_run_pattern()
> function:
>
> ERROR: "fsl_lbc_lock" [drivers/mtd/nand/fsl_upm.ko] undefined!
>
> Dave Jones purposed to export the lock, but it is better to just
> uninline
> the fsl_upm_run_pattern().
>
> When uninlined we also no longer need the exported fsl_lbc_regs, and
> both fsl_lbc_lock and fsl_lbc_regs could be marked static.
>
> While at it, also add some missing includes that we should have
> included
> explicitly.
>
> Reported-by: Dave Jones <davej@redhat.com>
> Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
> ---
applied.
- k
prev parent reply other threads:[~2008-10-13 16:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-08 22:28 fsl_upm compile failure Dave Jones
2008-10-08 23:02 ` Anton Vorontsov
2008-10-08 23:17 ` Anton Vorontsov
2008-10-08 23:33 ` Dave Jones
2008-10-09 0:32 ` [PATCH] powerpc: fix fsl_upm nand driver modular build Anton Vorontsov
2008-10-13 16:48 ` Kumar Gala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=141BB874-FDA4-4107-BEF6-15B84023E44B@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=avorontsov@ru.mvista.com \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®