From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D980132F75B for ; Wed, 1 Apr 2026 07:14:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775027643; cv=none; b=QrfBCgK3QiV0o/FDJk/33HnLPUHKUZvgRqA1CtKKoEqPXY90669U4NCqCfFmccEzDw7PcxF3JZ36pDy72HPbG7v9tsH7miTqmNeUfBNkbunKYPdFLEKKg19yn/TrtdMwyjq6EzSWCqWKaPRE1eAeuJMqcYQBl3iqyolQQZUodcY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775027643; c=relaxed/simple; bh=kMuwoW/ecMxCaLc3BF8Fg7DtCHJiVtLn7nasjByYDJ8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=L5o+Wa6xxn8zmsAEjEi8/zSAqs2CwE95ELnSIOqEDIszlPokTTFLH+GVtlmLEtomP7WU3f2ZzTaPAkuikAS4M7UfrmeAkud90UNXi3JNLAZhn8rKsTWbTs1fP4enapC5nY+GDhZvUX1s8O42pXoVPB7aUOcrLU2tOWAq5XNrQfQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JwhcGhXe; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JwhcGhXe" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-43cfce3a195so1888848f8f.2 for ; Wed, 01 Apr 2026 00:14:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775027640; x=1775632440; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=l1j/IxoU5Guat3mjMlA6cX1gNAird+6fN7SyDo3AMgI=; b=JwhcGhXeTLAMCwShCa4+fnYQA1k4AQxP+nMDEOIuSlpkYQnlxmLIE5DEZjN7jr64rS ngjc+y/W596+8f1R4I9rRksAFgEX4iTtj/UnTuzdSIsxyHMg+ilA8VYTxrT9TOTnSY9F zMo+Dw76GDQLTgFJPq+hyE+bZhycDwq//0H1qwYO5jibheicMUcmGFGGOiU7jSfoCg1D 7ZXxD7MVTMKvZ2JW/9f5i+MBMmXTaZAE4MnsSxvicMxvTX7w1uWfEiT4m5CuUF2xYyOh CxmNMcgKaiR/Yp0wrp3Q2veovAoG4MaxVKRWwP5gagQxSCB/byDN0gptpyQ7bvMQDVGd 0fvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775027640; x=1775632440; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=l1j/IxoU5Guat3mjMlA6cX1gNAird+6fN7SyDo3AMgI=; b=T9nfuCfdli4iQNqliTcIFzMSOSd+t7hUsi4FQ9u+75bK2ucvHfc6LUAhB6SAAVA64w +ndJjzP3BZF4widaIh5BPbEC+6wos7/S6xlmxjVFgsi9c7kMWwjTdVtKZhF6E33Bh1K0 5Z/DdrhFv3//XwwVw2L9ayxXTWBmJSvBf2jdZLTrVplSlWTBvlR6tuT8jpkhqnQ3OUAi IeUzihpYNPNoqCkz7WFgUCD16KgEB8cstRs1MprSNHhU+VTUWK+vaGb7gByjQiAq+dtw zK5CumhE1CKjruHGcvhdmrmeNR4u/X8PWMebhIxlm3HdqybdHQsgK2TFnN60NFQdllZJ 69vg== X-Forwarded-Encrypted: i=1; AJvYcCUNKBKNRaPxNTLh4X4x6CquTCrHYjvImpz4l9F/tG887cGS4LjayTtV14psKwpMlnO9tshEOZYLtAI+yWM=@vger.kernel.org X-Gm-Message-State: AOJu0Yxz9x+TnrGGknnN9oX9/3oq6QgVblN6mEnLO4B/h6ulFf1FQGmy 0Q2LIhLel2jEtaTL5SE4rytfx9DTmkUOdiM1kGtJWK94ohceGxYHIyJi X-Gm-Gg: ATEYQzxhLtkUz9G4MHXEXLCCw1/m/Q0US7vLE12qEHgayBzczu7rKPnCsclvLNJKZJK EXoF+/FIQS6CxiANTs1+t8AWp5wnk20eCCiJRDLUjg1HZjjxbeRewG+Tp7B21/KAcuiK9wgWPve DBLcxZfcn806s8MUIchbJQkcRKDlHCmOtsERUzBk8AQS4sfWJ6oWltJm5sjavMig4HqAbNrxDuR ReXMWvTJIIKzWX6FJuiCzHtg/2hKupV5Pj+j6gRn+Cnj7G+ZVwNDjcjAKyRuMS1Kp1SU5RGTP4g IyrKyUSZ5sVXqC7hTRuzWRwI/XKKQcB0cTzvXaoO70doz+3oSuu9FN3mlP9Z01ibniH2S9t/S94 tAHEH2oTL1dlTze2ZRzTc+HovndtLxMeYTBPJTRxKAQvUGzLZOGXjkDhbhwwXlz/lU3khbAzEPN OzcfH2YdDYqkMd52m8H7QKsNSn2YgXT+iL8gssREcaiIZDo/6c7cLtKFMg63Snzew= X-Received: by 2002:a05:6000:402a:b0:43b:4d37:cd37 with SMTP id ffacd0b85a97d-43d1504d681mr4462782f8f.7.1775027639943; Wed, 01 Apr 2026 00:13:59 -0700 (PDT) Received: from [192.168.20.170] (5D59A51C.catv.pool.telekom.hu. [93.89.165.28]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43cf21e265fsm35187403f8f.1.2026.04.01.00.13.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Apr 2026 00:13:59 -0700 (PDT) Message-ID: <141b3528-f83a-4fc3-954f-630ce45e54df@gmail.com> Date: Wed, 1 Apr 2026 09:13:57 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH phy-fixes] phy: marvell: mvebu-a3700-utmi: fix incorrect USB2_PHY_CTRL register access Content-Language: hu To: Miquel Raynal Cc: Vinod Koul , Neil Armstrong , Igal Liberman , Kishon Vijay Abraham I , linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260321-a3700-utmi-fix-usb2_phy_ctrl-access-v1-1-6005ff4b5058@gmail.com> <87zf3o873b.fsf@bootlin.com> From: Gabor Juhos In-Reply-To: <87zf3o873b.fsf@bootlin.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Miquel, > Hi Gabor, > > On 21/03/2026 at 15:42:32 +01, Gabor Juhos wrote: > >> The mvebu_a3700_utmi_phy_power_off() function tries to modify the >> USB2_PHY_CTRL register by using the IO address of the PHY IP block along >> with the readl/writel IO accessors. However, the register exist in the >> USB miscellaneous register space, and as such it must be accessed via >> regmap like it is done in the mvebu_a3700_utmi_phy_power_on() function. >> >> Change the code to use regmap_update_bits() for modífying the register > > Spurious accent here :-) ^ > > Do you imply that the register access was not working? Or that it was > not using the correct API? ... It was using the wrong API with wrong base address. The USB2_PHY_CTRL(x) macro gives back an offset relative to the base address of the USB miscellaneous registers. However the current code uses that offset with the base address of the UTMI PHY registers. So, instead of modifying the 'USB2 Host PHY Control' register at 0xd005f804 it changes the 'USB2 UTMI PHY PLL Control 1' register at 0xd005f004. Since the miscellaneous registers can be accessed only via the regmap obtained from a syscon node we have to use the regmap API instead of the generic IO accessors. > ... (hence potential issues with locking might arise) The regmap API uses built-in locking so there should be no locking issues. Regards, Gabor