mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <Tudor.Ambarus@microchip.com>
To: <yogeshnarayan.gaur@nxp.com>, <linux-mtd@lists.infradead.org>,
	<boris.brezillon@bootlin.com>, <broonie@kernel.org>,
	<marek.vasut@gmail.com>, <vigneshr@ti.com>,
	<linux-spi@vger.kernel.org>, <devicetree@vger.kernel.org>
Cc: <robh@kernel.org>, <mark.rutland@arm.com>, <shawnguo@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<computersforpeace@gmail.com>, <frieder.schrempf@exceet.de>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 3/7] mtd: spi-nor: add opcodes for octal Read/Write commands
Date: Tue, 11 Dec 2018 08:09:40 +0000	[thread overview]
Message-ID: <141c6d79-ae7a-60aa-865a-f6b6997f8da9@microchip.com> (raw)
In-Reply-To: <VI1PR04MB57264CBB25E2984DF221ED2E99A60@VI1PR04MB5726.eurprd04.prod.outlook.com>

Hi,

On 12/11/2018 06:55 AM, Yogesh Narayan Gaur wrote:
> Thus would going to modify the condition check as below, so that SFDP parsing would also be performed when SPI_NOR_OCTAL_READ is set. Correct?
> 
>         if ((info->flags & (SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
>              SPI_NOR_OCTAL_READ)) && !(info->flags & SPI_NOR_SKIP_SFDP)) {

Yes, this is what I was suggesting. On a second thought, we haven't added yet
support for parsing sfdp to get the octal mode info, so the parsing will be done
gratuitously. Let's drop this change and add it when adding support for parsing
octal mode info from sfdp. I'll prepare a patch for this.

Please rebase on top of spi-nor/next, s/octo/octal in spi-nor.h and correct your
S-o-b tag and you'll have my R-b tag.

Thanks Yogesh,
ta

  reply	other threads:[~2018-12-11  8:09 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-03  8:39 [PATCH v5 0/7] spi: add support for octal mode Yogesh Narayan Gaur
2018-12-03  8:39 ` [PATCH v5 1/7] spi: add support for octal mode I/O data transfer Yogesh Narayan Gaur
2018-12-04 17:27   ` Applied "spi: add support for octal mode I/O data transfer" to the spi tree Mark Brown
2018-12-03  8:39 ` [PATCH v5 2/7] spi: spi-mem: add support for octal mode I/O data transfer Yogesh Narayan Gaur
2018-12-03  8:39 ` [PATCH v5 3/7] mtd: spi-nor: add opcodes for octal Read/Write commands Yogesh Narayan Gaur
2018-12-10 10:44   ` Tudor.Ambarus
2018-12-11  4:55     ` Yogesh Narayan Gaur
2018-12-11  8:09       ` Tudor.Ambarus [this message]
2018-12-19 10:15         ` Yogesh Narayan Gaur
2018-12-10 10:57   ` Boris Brezillon
2018-12-10 11:17     ` Yogesh Narayan Gaur
2018-12-10 11:27       ` Boris Brezillon
2018-12-10 11:28         ` Yogesh Narayan Gaur
2018-12-03  8:39 ` [PATCH v5 4/7] mtd: spi-nor: add octal read flag for flash mt35xu512aba Yogesh Narayan Gaur
2018-12-03  8:39 ` [PATCH v5 5/7] mtd: m25p80: add support of octal mode I/O transfer Yogesh Narayan Gaur
2018-12-03  8:39 ` [PATCH v5 6/7] spi: nxp-fspi: add octal mode flag bit for octal support Yogesh Narayan Gaur
2018-12-03  8:39 ` [PATCH v5 7/7] arm64: dts: lx2160a: update fspi node Yogesh Narayan Gaur
2018-12-03  9:19 ` [PATCH v5 0/7] spi: add support for octal mode Boris Brezillon
2018-12-05 11:55   ` Vignesh R
2018-12-05 12:46     ` Boris Brezillon
2018-12-05 14:18       ` Mark Brown
2018-12-06  4:20       ` Yogesh Narayan Gaur
2018-12-06  6:45         ` Boris Brezillon
2018-12-06  6:49           ` Yogesh Narayan Gaur
2018-12-06 20:29             ` Mark Brown
2018-12-10  4:13               ` Yogesh Narayan Gaur
2018-12-10  8:22                 ` Boris Brezillon
2018-12-10  8:39                   ` Yogesh Narayan Gaur
2018-12-10  8:50                     ` Boris Brezillon
2018-12-10 15:29                 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=141c6d79-ae7a-60aa-865a-f6b6997f8da9@microchip.com \
    --to=tudor.ambarus@microchip.com \
    --cc=boris.brezillon@bootlin.com \
    --cc=broonie@kernel.org \
    --cc=computersforpeace@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=frieder.schrempf@exceet.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=marek.vasut@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=robh@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=vigneshr@ti.com \
    --cc=yogeshnarayan.gaur@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®