From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752349AbbABSRX (ORCPT ); Fri, 2 Jan 2015 13:17:23 -0500 Received: from cpsmtpb-ews10.kpnxchange.com ([213.75.39.15]:62212 "EHLO cpsmtpb-ews10.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752090AbbABSRU (ORCPT ); Fri, 2 Jan 2015 13:17:20 -0500 Message-ID: <1420222637.9624.36.camel@x220> Subject: Re: [PATCH] sound: pci: hda: patch_analog: Remove some unused functions From: Paul Bolle To: Rickard Strandqvist Cc: Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Date: Fri, 02 Jan 2015 19:17:17 +0100 In-Reply-To: <1420221508-32319-1-git-send-email-rickard_strandqvist@spectrumdigital.se> References: <1420221508-32319-1-git-send-email-rickard_strandqvist@spectrumdigital.se> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 02 Jan 2015 18:17:17.0953 (UTC) FILETIME=[579D9F10:01D026B8] X-RcptDomain: vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2015-01-02 at 18:58 +0100, Rickard Strandqvist wrote: > Removes some functions that are not used anywhere: > ad198x_ch_mode_put() ad198x_ch_mode_info() > > This was partially found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist > --- You apparently overlooked _your_ commit 57da6bdd4823 ("ALSA: hda - patch_analog.c: Remove some unused functions") in linux-next. > sound/pci/hda/patch_analog.c | 21 --------------------- > 1 file changed, 21 deletions(-) > > diff --git a/sound/pci/hda/patch_analog.c b/sound/pci/hda/patch_analog.c > index 06275f8..ed0b71c 100644 > --- a/sound/pci/hda/patch_analog.c > +++ b/sound/pci/hda/patch_analog.c > @@ -698,15 +698,6 @@ static int patch_ad1981(struct hda_codec *codec) > */ > > #ifdef ENABLE_AD_STATIC_QUIRKS > -static int ad198x_ch_mode_info(struct snd_kcontrol *kcontrol, > - struct snd_ctl_elem_info *uinfo) > -{ > - struct hda_codec *codec = snd_kcontrol_chip(kcontrol); > - struct ad198x_spec *spec = codec->spec; > - return snd_hda_ch_mode_info(codec, uinfo, spec->channel_mode, > - spec->num_channel_mode); > -} > - > static int ad198x_ch_mode_get(struct snd_kcontrol *kcontrol, > struct snd_ctl_elem_value *ucontrol) > { > @@ -716,18 +707,6 @@ static int ad198x_ch_mode_get(struct snd_kcontrol *kcontrol, > spec->num_channel_mode, spec->multiout.max_channels); > } > > -static int ad198x_ch_mode_put(struct snd_kcontrol *kcontrol, > - struct snd_ctl_elem_value *ucontrol) > -{ > - struct hda_codec *codec = snd_kcontrol_chip(kcontrol); > - struct ad198x_spec *spec = codec->spec; > - int err = snd_hda_ch_mode_put(codec, ucontrol, spec->channel_mode, > - spec->num_channel_mode, > - &spec->multiout.max_channels); > - if (err >= 0 && spec->need_dac_fix) > - spec->multiout.num_dacs = spec->multiout.max_channels / 2; > - return err; > -} > #endif /* ENABLE_AD_STATIC_QUIRKS */ > > static int ad1988_auto_smux_enum_info(struct snd_kcontrol *kcontrol, Thanks, Paul Bolle