From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Sam Ravnborg <sam@ravnborg.org>,
"David S. Miller" <davem@davemloft.net>,
sparclinux@vger.kernel.org
Subject: [PATCH] sparc64: minor coding style tweaks
Date: Tue, 6 Jan 2015 23:39:59 +0200 [thread overview]
Message-ID: <1420580314-15107-1-git-send-email-mst@redhat.com> (raw)
Sam Ravnborg suggested packing single-line cases
in nocheck switch statements makes for easier to
read code.
This is on top of arch/sparc: uaccess_64 macro whitespace fixes
that I sent earlier.
Suggested-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
arch/sparc/include/asm/uaccess_64.h | 100 +++++++++++++-----------------------
1 file changed, 37 insertions(+), 63 deletions(-)
diff --git a/arch/sparc/include/asm/uaccess_64.h b/arch/sparc/include/asm/uaccess_64.h
index 12d9594..a35194b 100644
--- a/arch/sparc/include/asm/uaccess_64.h
+++ b/arch/sparc/include/asm/uaccess_64.h
@@ -106,26 +106,16 @@ void __retl_efault(void);
struct __large_struct { unsigned long buf[100]; };
#define __m(x) ((struct __large_struct *)(x))
-#define __put_user_nocheck(data, addr, size) ({ \
- register int __pu_ret; \
- switch (size) { \
- case 1: \
- __put_user_asm(data, b, addr, __pu_ret); \
- break; \
- case 2: \
- __put_user_asm(data, h, addr, __pu_ret); \
- break; \
- case 4: \
- __put_user_asm(data, w, addr, __pu_ret); \
- break; \
- case 8: \
- __put_user_asm(data, x, addr, __pu_ret); \
- break; \
- default: \
- __pu_ret = __put_user_bad(); \
- break; \
- } \
- __pu_ret; \
+#define __put_user_nocheck(data, addr, size) ({ \
+ register int __pu_ret; \
+ switch (size) { \
+ case 1: __put_user_asm(data, b, addr, __pu_ret); break; \
+ case 2: __put_user_asm(data, h, addr, __pu_ret); break; \
+ case 4: __put_user_asm(data, w, addr, __pu_ret); break; \
+ case 8: __put_user_asm(data, x, addr, __pu_ret); break; \
+ default: __pu_ret = __put_user_bad(); break; \
+ } \
+ __pu_ret; \
})
#define __put_user_asm(x, size, addr, ret) \
@@ -150,51 +140,35 @@ __asm__ __volatile__( \
int __put_user_bad(void);
-#define __get_user_nocheck(data, addr, size, type) ({ \
- register int __gu_ret; \
- register unsigned long __gu_val; \
- switch (size) { \
- case 1: \
- __get_user_asm(__gu_val, ub, addr, __gu_ret); \
- break; \
- case 2: \
- __get_user_asm(__gu_val, uh, addr, __gu_ret); \
- break; \
- case 4: \
- __get_user_asm(__gu_val, uw, addr, __gu_ret); \
- break; \
- case 8: \
- __get_user_asm(__gu_val, x, addr, __gu_ret); \
- break; \
- default: \
- __gu_val = 0; \
- __gu_ret = __get_user_bad(); \
- break; \
- } \
- data = (__force type) __gu_val; \
- __gu_ret; \
+#define __get_user_nocheck(data, addr, size, type) ({ \
+ register int __gu_ret; \
+ register unsigned long __gu_val; \
+ switch (size) { \
+ case 1: __get_user_asm(__gu_val, ub, addr, __gu_ret); break; \
+ case 2: __get_user_asm(__gu_val, uh, addr, __gu_ret); break; \
+ case 4: __get_user_asm(__gu_val, uw, addr, __gu_ret); break; \
+ case 8: __get_user_asm(__gu_val, x, addr, __gu_ret); break; \
+ default: \
+ __gu_val = 0; \
+ __gu_ret = __get_user_bad(); \
+ break; \
+ } \
+ data = (__force type) __gu_val; \
+ __gu_ret; \
})
-#define __get_user_nocheck_ret(data, addr, size, type, retval) ({ \
- register unsigned long __gu_val __asm__ ("l1"); \
- switch (size) { \
- case 1: \
- __get_user_asm_ret(__gu_val, ub, addr, retval); \
- break; \
- case 2: \
- __get_user_asm_ret(__gu_val, uh, addr, retval); \
- break; \
- case 4: \
- __get_user_asm_ret(__gu_val, uw, addr, retval); \
- break; \
- case 8: \
- __get_user_asm_ret(__gu_val, x, addr, retval); \
- break; \
- default: \
- if (__get_user_bad()) \
- return retval; \
- } \
- data = (__force type) __gu_val; \
+#define __get_user_nocheck_ret(data, addr, size, type, retval) ({ \
+ register unsigned long __gu_val __asm__ ("l1"); \
+ switch (size) { \
+ case 1: __get_user_asm_ret(__gu_val, ub, addr, retval); break; \
+ case 2: __get_user_asm_ret(__gu_val, uh, addr, retval); break; \
+ case 4: __get_user_asm_ret(__gu_val, uw, addr, retval); break; \
+ case 8: __get_user_asm_ret(__gu_val, x, addr, retval); break; \
+ default: \
+ if (__get_user_bad()) \
+ return retval; \
+ } \
+ data = (__force type) __gu_val; \
})
#define __get_user_asm(x, size, addr, ret) \
--
MST
next reply other threads:[~2015-01-06 21:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-06 21:39 Michael S. Tsirkin [this message]
2015-01-07 6:18 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420580314-15107-1-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome