mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: kbuild-all@01.org, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [target:nvme_of 3/3] drivers/target/nvme_of/nvme_of_configfs.c:25:31: sparse: symbol 'nvme_of_fabric_configfs' was not declared. Should it be static?
Date: Tue, 06 Jan 2015 14:44:42 -0800	[thread overview]
Message-ID: <1420584282.6927.62.camel@haakon3.risingtidesystems.com> (raw)
In-Reply-To: <201501070334.EgwC5iey%fengguang.wu@intel.com>

On Wed, 2015-01-07 at 03:35 +0800, kbuild test robot wrote:
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git nvme_of
> head:   40d8c11927282d59855d645b35798edd97828da5
> commit: 40d8c11927282d59855d645b35798edd97828da5 [3/3] nvme_of: Initial skeleton commit
> reproduce:
>   # apt-get install sparse
>   git checkout 40d8c11927282d59855d645b35798edd97828da5
>   make ARCH=x86_64 allmodconfig
>   make C=1 CF=-D__CHECK_ENDIAN__
> 
> 
> sparse warnings: (new ones prefixed by >>)
> 
> >> drivers/target/nvme_of/nvme_of_configfs.c:25:31: sparse: symbol 'nvme_of_fabric_configfs' was not declared. Should it be static?
> 
> Please review and possibly fold the followup patch.
> 

Fixed.  Thanks Fengguang!

--nab


  parent reply	other threads:[~2015-01-06 22:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-06 19:35 kbuild test robot
2015-01-06 19:35 ` [PATCH target] nvme_of: nvme_of_fabric_configfs can be static kbuild test robot
2015-01-06 22:44 ` Nicholas A. Bellinger [this message]
2015-01-07  8:57   ` [target:nvme_of 3/3] drivers/target/nvme_of/nvme_of_configfs.c:25:31: sparse: symbol 'nvme_of_fabric_configfs' was not declared. Should it be static? Sagi Grimberg
2015-01-07 18:22     ` Nicholas A. Bellinger
2015-01-07 20:26       ` Sagi Grimberg
2015-01-07 21:33         ` Nicholas A. Bellinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1420584282.6927.62.camel@haakon3.risingtidesystems.com \
    --to=nab@linux-iscsi.org \
    --cc=fengguang.wu@intel.com \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®