From: Cyril Bur <cyrilbur@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: mpe@ellerman.id.au, drjones@redhat.com, dzickus@redhat.com,
akpm@linux-foundation.org, mingo@kernel.org, uobergfe@redhat.com,
chaiw.fnst@cn.fujitsu.com, fabf@skynet.be, atomlin@redhat.com,
benzh@chromium.org, schwidefsky@de.ibm.com,
Cyril Bur <cyrilbur@gmail.com>
Subject: [PATCH v2 1/2] Add another clock for use with the soft lockup watchdog.
Date: Fri, 9 Jan 2015 14:34:37 +1100 [thread overview]
Message-ID: <1420774478-16760-2-git-send-email-cyrilbur@gmail.com> (raw)
In-Reply-To: <1420774478-16760-1-git-send-email-cyrilbur@gmail.com>
This permits the use of arch specific clocks for which virtualised kernels can
use their notion of 'running' time, not the elpased wall time which will
include host execution time.
Signed-off-by: Cyril Bur <cyrilbur@gmail.com>
---
V2:
Remove the export of running_clock
Use local_clock instead of sched_clock as was initally used in the
softlockup detector
---
include/linux/sched.h | 1 +
kernel/sched/clock.c | 13 +++++++++++++
kernel/watchdog.c | 2 +-
3 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/include/linux/sched.h b/include/linux/sched.h
index 8db31ef..e400162 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -2145,6 +2145,7 @@ extern unsigned long long notrace sched_clock(void);
*/
extern u64 cpu_clock(int cpu);
extern u64 local_clock(void);
+extern u64 running_clock(void);
extern u64 sched_clock_cpu(int cpu);
diff --git a/kernel/sched/clock.c b/kernel/sched/clock.c
index c27e4f8..c0a2051 100644
--- a/kernel/sched/clock.c
+++ b/kernel/sched/clock.c
@@ -420,3 +420,16 @@ u64 local_clock(void)
EXPORT_SYMBOL_GPL(cpu_clock);
EXPORT_SYMBOL_GPL(local_clock);
+
+/*
+ * Running clock - returns the time that has elapsed while a guest has been
+ * running.
+ * On a guest this value should be local_clock minus the time the guest was
+ * suspended by the hypervisor (for any reason).
+ * On bare metal this function should return the same as local_clock.
+ * Architectures and sub-architectures can override this.
+ */
+u64 __weak running_clock(void)
+{
+ return local_clock();
+}
diff --git a/kernel/watchdog.c b/kernel/watchdog.c
index 70bf118..3174bf8 100644
--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -154,7 +154,7 @@ static int get_softlockup_thresh(void)
*/
static unsigned long get_timestamp(void)
{
- return local_clock() >> 30LL; /* 2^30 ~= 10^9 */
+ return running_clock() >> 30LL; /* 2^30 ~= 10^9 */
}
static void set_sample_period(void)
--
1.9.1
next prev parent reply other threads:[~2015-01-09 3:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 3:34 [PATCH v2 0/2] Quieten softlockup detector on virtualised kernels Cyril Bur
2015-01-09 3:34 ` Cyril Bur [this message]
2015-02-10 6:19 ` [PATCH v2 1/2] Add another clock for use with the soft lockup watchdog Chai Wen
2015-01-09 3:34 ` [PATCH v2 2/2] powerpc: add running_clock for powerpc to prevent spurious softlockup warnings Cyril Bur
2015-02-04 10:42 ` Paul Bolle
2015-02-05 4:08 ` Cyril Bur
2015-02-02 4:58 ` [PATCH v2 0/2] Quieten softlockup detector on virtualised kernels Cyril Bur
2015-02-02 23:08 ` Andrew Morton
2015-02-05 20:48 ` Don Zickus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420774478-16760-2-git-send-email-cyrilbur@gmail.com \
--to=cyrilbur@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=atomlin@redhat.com \
--cc=benzh@chromium.org \
--cc=chaiw.fnst@cn.fujitsu.com \
--cc=drjones@redhat.com \
--cc=dzickus@redhat.com \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=schwidefsky@de.ibm.com \
--cc=uobergfe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome