From: Michael Ellerman <mpe@ellerman.id.au>
To: <linux-kernel@vger.kernel.org>
Cc: mmarek@suse.cz, gregkh@linuxfoundation.org,
akpm@linux-foundation.org, rostedt@goodmis.org, mingo@redhat.com,
davem@davemloft.net, keescook@chromium.org,
tranmanphong@gmail.com, cov@codeaurora.org,
dh.herrmann@gmail.com, hughd@google.com, bobby.prani@gmail.com,
serge.hallyn@ubuntu.com, ebiederm@xmission.com,
tim.bird@sonymobile.com, josh@joshtriplett.org, koct9i@gmail.com,
linux-kbuild@vger.kernel.org, linux-api@vger.kernel.org,
netdev@vger.kernel.org, shuahkh@osg.samsung.com
Subject: [PATCH 5/6] kbuild: Don't pass -rR to selftest makefiles
Date: Fri, 9 Jan 2015 20:06:14 +1100 [thread overview]
Message-ID: <1420794375-31881-5-git-send-email-mpe@ellerman.id.au> (raw)
In-Reply-To: <1420794375-31881-1-git-send-email-mpe@ellerman.id.au>
The makefiles under tools/testing/selftests are not real kbuild
makefiles, they are regular stand alone makefiles. As such they *do*
want all the standard implicit rules and variables defined.
So before calling those makefiles, filter -rR out of MAKEFLAGS.
Without this not all the selftests are built correctly when called via
the top-level Makefile.
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index c186a928d8be..8bbd0bc7329c 100644
--- a/Makefile
+++ b/Makefile
@@ -1079,12 +1079,12 @@ INSTALL_SELFTESTS_PATH = $(abspath $(objtree)/selftests)
PHONY += kselftest
kselftest:
- $(Q)$(MAKE) -C tools/testing/selftests run_tests
+ $(Q)$(MAKE) -C tools/testing/selftests MAKEFLAGS="$(filter-out rR,$(MAKEFLAGS))" run_tests
# Kernel selftest install
PHONY += kselftest_install
kselftest_install:
- $(Q)$(MAKE) -C tools/testing/selftests INSTALL_PATH=$(INSTALL_SELFTESTS_PATH) install
+ $(Q)$(MAKE) -C tools/testing/selftests MAKEFLAGS="$(filter-out rR,$(MAKEFLAGS))" INSTALL_PATH=$(INSTALL_SELFTESTS_PATH) install
# ---------------------------------------------------------------------------
# Modules
--
2.1.0
next prev parent reply other threads:[~2015-01-09 9:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 9:06 [PATCH 1/6] selftests: Introduce minimal shared logic for running tests Michael Ellerman
2015-01-09 9:06 ` [PATCH 2/6] selftests: Add install target Michael Ellerman
2015-01-16 17:46 ` Shuah Khan
2015-01-19 0:35 ` Michael Ellerman
2015-01-19 16:35 ` Shuah Khan
2015-01-20 3:13 ` Michael Ellerman
2015-01-09 9:06 ` [PATCH 3/6] selftests: Add install support for the powerpc tests Michael Ellerman
2015-01-09 9:06 ` [PATCH 4/6] kbuild: add a new kselftest_install make target to install selftests Michael Ellerman
2015-01-16 16:34 ` Shuah Khan
2015-01-19 0:35 ` Michael Ellerman
2015-01-19 16:34 ` Shuah Khan
2015-01-09 9:06 ` Michael Ellerman [this message]
2015-01-09 9:06 ` [PATCH 6/6] selftests: Set CC using CROSS_COMPILE once in lib.mk Michael Ellerman
2015-01-16 16:37 ` Shuah Khan
2015-01-16 17:53 ` [PATCH 1/6] selftests: Introduce minimal shared logic for running tests Shuah Khan
2015-01-19 0:35 ` Michael Ellerman
2015-01-19 16:39 ` Shuah Khan
2015-01-20 3:08 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420794375-31881-5-git-send-email-mpe@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=akpm@linux-foundation.org \
--cc=bobby.prani@gmail.com \
--cc=cov@codeaurora.org \
--cc=davem@davemloft.net \
--cc=dh.herrmann@gmail.com \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=hughd@google.com \
--cc=josh@joshtriplett.org \
--cc=keescook@chromium.org \
--cc=koct9i@gmail.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mmarek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=serge.hallyn@ubuntu.com \
--cc=shuahkh@osg.samsung.com \
--cc=tim.bird@sonymobile.com \
--cc=tranmanphong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®