From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752495AbbALR2q (ORCPT ); Mon, 12 Jan 2015 12:28:46 -0500 Received: from mx02.posteo.de ([89.146.194.165]:45167 "EHLO mx02.posteo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751085AbbALR2n (ORCPT ); Mon, 12 Jan 2015 12:28:43 -0500 From: Martin Kepplinger To: mingo@kernel.org Cc: peterz@infradead.org, paulmck@linux.vnet.ibm.com, tytso@mit.edu, maxime.coquelin@st.com, linux@roeck-us.net, linux-kernel@vger.kernel.org, Martin Kepplinger Subject: [RFC] rtc: use sign_extend8 instead of manual conversion Date: Mon, 12 Jan 2015 18:28:18 +0100 Message-Id: <1421083700-25258-2-git-send-email-martink@posteo.de> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1421083700-25258-1-git-send-email-martink@posteo.de> References: <1421083370-24924-1-git-send-email-martink@posteo.de> <1421083700-25258-1-git-send-email-martink@posteo.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Example change, using new sign_extend functions. --- drivers/rtc/rtc-x1205.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-x1205.c b/drivers/rtc/rtc-x1205.c index b1de58e..3ec0b95 100644 --- a/drivers/rtc/rtc-x1205.c +++ b/drivers/rtc/rtc-x1205.c @@ -22,6 +22,7 @@ #include #include #include +#include #define DRV_VERSION "1.0.8" @@ -366,8 +367,7 @@ static int x1205_get_atrim(struct i2c_client *client, int *trim) * perform sign extension. The formula is * Catr = (atr * 0.25pF) + 11.00pF. */ - if (atr & 0x20) - atr |= 0xC0; + atr = sign_extend8(atr, 5); dev_dbg(&client->dev, "%s: raw atr=%x (%d)\n", __func__, atr, atr); -- 2.1.4