From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753024AbbAMQPR (ORCPT ); Tue, 13 Jan 2015 11:15:17 -0500 Received: from mail-pd0-f172.google.com ([209.85.192.172]:49529 "EHLO mail-pd0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751622AbbAMQPO (ORCPT ); Tue, 13 Jan 2015 11:15:14 -0500 From: Sudip Mukherjee To: Ferenc Bakonyi , Jean-Christophe Plagniol-Villard , Tomi Valkeinen Cc: Sudip Mukherjee , linux-nvidia@lists.surfsouth.com, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] video: hgafb: remove unneeded comparison Date: Tue, 13 Jan 2015 21:44:59 +0530 Message-Id: <1421165699-9033-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.8.1.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org var->yoffset is of the type __u32, hence the comparison will always be false. Signed-off-by: Sudip Mukherjee --- drivers/video/fbdev/hgafb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/fbdev/hgafb.c b/drivers/video/fbdev/hgafb.c index 5ff9fe2..15d3ccf 100644 --- a/drivers/video/fbdev/hgafb.c +++ b/drivers/video/fbdev/hgafb.c @@ -417,8 +417,7 @@ static int hgafb_pan_display(struct fb_var_screeninfo *var, struct fb_info *info) { if (var->vmode & FB_VMODE_YWRAP) { - if (var->yoffset < 0 || - var->yoffset >= info->var.yres_virtual || + if (var->yoffset >= info->var.yres_virtual || var->xoffset) return -EINVAL; } else { -- 1.8.1.2