From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932503AbbAOWTo (ORCPT ); Thu, 15 Jan 2015 17:19:44 -0500 Received: from ozlabs.org ([103.22.144.67]:39049 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755723AbbAOWTn (ORCPT ); Thu, 15 Jan 2015 17:19:43 -0500 Message-ID: <1421360377.23332.1.camel@ellerman.id.au> Subject: Re: [PATCH] pseries/le: Fix another endiannes issue in RTAS call from xmon From: Michael Ellerman To: Tyrel Datwyler Cc: Laurent Dufour , paulus@samba.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Date: Fri, 16 Jan 2015 09:19:37 +1100 In-Reply-To: <54B8188D.1060907@linux.vnet.ibm.com> References: <1421295950.11409.3.camel@ellerman.id.au> <1421342627-7214-1-git-send-email-ldufour@linux.vnet.ibm.com> <54B8188D.1060907@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.7-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2015-01-15 at 11:44 -0800, Tyrel Datwyler wrote: > On 01/15/2015 09:23 AM, Laurent Dufour wrote: > > The commit 3b8a3c010969 ("powerpc/pseries: Fix endiannes issue in RTAS > > call from xmon") was fixing an endianness issue in the call made from > > xmon to RTAS. > > > > However, as Michael Ellerman noticed, this fix was not complete, the > > token value was not byte swapped. This lead to call an unexpected and > > most of the time unexisting RTAS function, which is silently ignored > > by RTAS. > > Nit. Not so much that is silently ignored by RTAS as much as > disable_surveillance silently doesn't check the return status of the > RTAS call. Maybe a check is warranted and reporting of non-success. Yeah you're right, I added a printf of the result and got -3, which is also wrong as far as I can tell, but I didn't have the energy to chase it any further. Because this is in xmon we want to be extra careful about what we do, but an xmon_printf() should be safe. I'll do that as a cleanup after this. cheers