From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753928AbbAPI52 (ORCPT ); Fri, 16 Jan 2015 03:57:28 -0500 Received: from mail-ie0-f172.google.com ([209.85.223.172]:45553 "EHLO mail-ie0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752615AbbAPI5W (ORCPT ); Fri, 16 Jan 2015 03:57:22 -0500 From: Jia He To: linux-kernel@vger.kernel.org Cc: Jia He , Jeremiah Mahler , Oleg Drokin , Andreas Dilger , Greg Kroah-Hartman Subject: [PATCH] staging: lustre: libcfs: fix sparse warnings about static declaration Date: Fri, 16 Jan 2015 16:58:12 +0800 Message-Id: <1421398692-21827-1-git-send-email-hejianet@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <20150114063518.GA18644@hudson.localdomain> References: <20150114063518.GA18644@hudson.localdomain> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org These functions kportal_memhog_{alloc,free} aren't used outside of this file, so making them static to suppress the sparse warnings about static declaration. Besides, this also fixes the space warning checked by checkpatch.pl Signed-off-by: Jia He Cc: Jeremiah Mahler Cc: Oleg Drokin Cc: Andreas Dilger Cc: Greg Kroah-Hartman --- drivers/staging/lustre/lustre/libcfs/module.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/lustre/lustre/libcfs/module.c b/drivers/staging/lustre/lustre/libcfs/module.c index 2c4fc74..1af6a37 100644 --- a/drivers/staging/lustre/lustre/libcfs/module.c +++ b/drivers/staging/lustre/lustre/libcfs/module.c @@ -42,8 +42,7 @@ #include "../../include/linux/lnet/lnet.h" #include "tracefile.h" -void -kportal_memhog_free (struct libcfs_device_userstate *ldu) +static void kportal_memhog_free(struct libcfs_device_userstate *ldu) { struct page **level0p = &ldu->ldu_memhog_root_page; struct page **level1p; @@ -86,8 +85,7 @@ kportal_memhog_free (struct libcfs_device_userstate *ldu) LASSERT (ldu->ldu_memhog_pages == 0); } -int -kportal_memhog_alloc(struct libcfs_device_userstate *ldu, int npages, +static int kportal_memhog_alloc(struct libcfs_device_userstate *ldu, int npages, gfp_t flags) { struct page **level0p; -- 1.9.1