From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: John Stultz <john.stultz@linaro.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Alexandre Belloni <alexandre.belloni@free-electrons.com>
Subject: [RFC 1/2] clocksource: track usage
Date: Fri, 16 Jan 2015 10:17:53 +0100 [thread overview]
Message-ID: <1421399874-29119-2-git-send-email-alexandre.belloni@free-electrons.com> (raw)
In-Reply-To: <1421399874-29119-1-git-send-email-alexandre.belloni@free-electrons.com>
Track whether the clocksource is enabled or disabled.
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
include/linux/clocksource.h | 4 ++++
kernel/time/clocksource.c | 26 ++++++++++++++++++++++++++
kernel/time/timekeeping.c | 8 +++-----
3 files changed, 33 insertions(+), 5 deletions(-)
diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h
index abcafaa20b86..7735902fc5f6 100644
--- a/include/linux/clocksource.h
+++ b/include/linux/clocksource.h
@@ -210,6 +210,8 @@ struct clocksource {
#define CLOCK_SOURCE_SUSPEND_NONSTOP 0x80
#define CLOCK_SOURCE_RESELECT 0x100
+#define CLOCK_SOURCE_USED 0x200
+
/* simplify initialization of mask field */
#define CLOCKSOURCE_MASK(bits) (cycle_t)((bits) < 64 ? ((1ULL<<(bits))-1) : -1)
@@ -282,6 +284,8 @@ static inline s64 clocksource_cyc2ns(cycle_t cycles, u32 mult, u32 shift)
extern int clocksource_register(struct clocksource*);
extern int clocksource_unregister(struct clocksource*);
+extern int clocksource_enable(struct clocksource *);
+extern void clocksource_disable(struct clocksource *);
extern void clocksource_touch_watchdog(void);
extern struct clocksource* clocksource_get_next(void);
extern void clocksource_change_rating(struct clocksource *cs, int rating);
diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c
index b79f39bda7e1..920a4da58eb0 100644
--- a/kernel/time/clocksource.c
+++ b/kernel/time/clocksource.c
@@ -889,6 +889,32 @@ int clocksource_unregister(struct clocksource *cs)
}
EXPORT_SYMBOL(clocksource_unregister);
+/**
+ * clocksource_enable - enable a registered clocksource
+ * @cs: clocksource to enable
+ */
+int clocksource_enable(struct clocksource *cs)
+{
+ cs->flags |= CLOCK_SOURCE_USED;
+ if (cs->enable)
+ return cs->enable(cs);
+
+ return 0;
+}
+EXPORT_SYMBOL(clocksource_enable);
+
+/**
+ * clocksource_disable - disable a registered clocksource
+ * @cs: clocksource to disable
+ */
+void clocksource_disable(struct clocksource *cs)
+{
+ cs->flags &= ~CLOCK_SOURCE_USED;
+ if (cs->disable)
+ cs->disable(cs);
+}
+EXPORT_SYMBOL(clocksource_disable);
+
#ifdef CONFIG_SYSFS
/**
* sysfs_show_current_clocksources - sysfs interface for current clocksource
diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
index 6a931852082f..1c6ffd3d068c 100644
--- a/kernel/time/timekeeping.c
+++ b/kernel/time/timekeeping.c
@@ -915,11 +915,10 @@ static int change_clocksource(void *data)
* for built-in code (owner == NULL) as well.
*/
if (try_module_get(new->owner)) {
- if (!new->enable || new->enable(new) == 0) {
+ if (!new->enable || clocksource_enable(new) == 0) {
old = tk->tkr.clock;
tk_setup_internals(tk, new);
- if (old->disable)
- old->disable(old);
+ clocksource_disable(old);
module_put(old->owner);
} else {
module_put(new->owner);
@@ -1080,8 +1079,7 @@ void __init timekeeping_init(void)
ntp_init();
clock = clocksource_default_clock();
- if (clock->enable)
- clock->enable(clock);
+ clocksource_enable(clock);
tk_setup_internals(tk, clock);
tk_set_xtime(tk, &now);
--
2.1.0
next prev parent reply other threads:[~2015-01-16 9:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 9:17 [RFC 0/2] clocksource: don't suspend/resume when unused Alexandre Belloni
2015-01-16 9:17 ` Alexandre Belloni [this message]
2015-01-16 10:39 ` [RFC 1/2] clocksource: track usage Boris Brezillon
2015-02-02 20:03 ` Kevin Hilman
2015-01-16 9:17 ` [RFC 2/2] clocksource: don't suspend/resume when unused Alexandre Belloni
2015-01-16 10:23 ` Thomas Gleixner
2015-01-16 10:35 ` Alexandre Belloni
2015-01-16 10:39 ` Daniel Lezcano
2015-01-16 10:48 ` Alexandre Belloni
2015-01-16 10:59 ` Daniel Lezcano
2015-01-16 11:07 ` Alexandre Belloni
2015-01-16 11:45 ` Alexandre Belloni
2015-01-16 11:23 ` Russell King - ARM Linux
2015-01-16 11:28 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421399874-29119-2-git-send-email-alexandre.belloni@free-electrons.com \
--to=alexandre.belloni@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=daniel.lezcano@linaro.org \
--cc=john.stultz@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®