mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pu Lehui <pulehui@huawei.com>
To: Tiezhu Yang <yangtiezhu@loongson.cn>,
	Andrii Nakryiko <andrii@kernel.org>,
	Eduard Zingerman <eddyz87@gmail.com>,
	Ihor Solodrai <ihor.solodrai@linux.dev>
Cc: <bpf@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH bpf-next v1] selftests/bpf: Add get_preempt_count() support for RISC-V
Date: Wed, 22 Jul 2026 10:51:07 +0800	[thread overview]
Message-ID: <14216058-3e55-4225-819f-9fce6ab7dffb@huawei.com> (raw)
In-Reply-To: <20260722022906.8778-1-yangtiezhu@loongson.cn>

Hi Tiezhu,

Thanks to respin it, we need this to cover more selftests.

On 2026/7/22 10:29, Tiezhu Yang wrote:
> Currently, there is no RISC-V support for get_preempt_count() and
> its fallback path always returns 0.
> 
> Add it so that bpf_in_interrupt(), bpf_in_nmi(), bpf_in_hardirq(),
> bpf_in_serving_softirq(), and bpf_in_task() work for RISC-V as well.
> 
> Given that RISC-V has supported CONFIG_THREAD_INFO_IN_TASK since its
> initial commit fbe934d69eb7 ("RISC-V: Build Infrastructure") in 2017,
> directly retrieve preempt_count from the thread_info embedded within
> task_struct via bpf_get_current_task_btf().
> 
> This aligns the implementation with arm64, powerpc, and loongarch.
> 
> Tested on a RISC-V virtual machine.
> 
> Before:
>    $ sudo ./test_progs -t exe_ctx
>    ...
>    #114     exe_ctx:FAIL
>    Summary: 0/0 PASSED, 0 SKIPPED, 1 FAILED
> 
> After:
>    $ sudo ./test_progs -t exe_ctx
>    #114     exe_ctx:OK
>    Summary: 1/0 PASSED, 0 SKIPPED, 0 FAILED
> 
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> Tested-by: Pu Lehui <pulehui@huawei.com>
> Reviewed-by: Pu Lehui <pulehui@huawei.com>
> ---
> RFC -> v1:
>    -- No code changes
>    -- Update the commit message
>    -- Add Tested-by and Reviewed-by
> https://lore.kernel.org/bpf/0191fe3f-b956-480d-aef2-a4d75f9e02de@huawei.com/
> 
>   tools/testing/selftests/bpf/bpf_experimental.h | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/tools/testing/selftests/bpf/bpf_experimental.h b/tools/testing/selftests/bpf/bpf_experimental.h
> index 67ff7882299e..ff37ae5a113d 100644
> --- a/tools/testing/selftests/bpf/bpf_experimental.h
> +++ b/tools/testing/selftests/bpf/bpf_experimental.h
> @@ -425,6 +425,8 @@ static inline int get_preempt_count(void)
>   	return bpf_get_lowcore()->preempt_count;
>   #elif defined(bpf_target_loongarch)
>   	return bpf_get_current_task_btf()->thread_info.preempt_count;
> +#elif defined(bpf_target_riscv)
> +	return bpf_get_current_task_btf()->thread_info.preempt_count;
>   #endif
>   	return 0;
>   }
> @@ -436,6 +438,7 @@ static inline int get_preempt_count(void)
>    *	* powerpc64
>    *	* s390x
>    *	* loongarch
> + *	* riscv
>    */
>   static inline int bpf_in_interrupt(void)
>   {
> @@ -458,6 +461,7 @@ static inline int bpf_in_interrupt(void)
>    *	* powerpc64
>    *	* s390x
>    *	* loongarch
> + *	* riscv
>    */
>   static inline int bpf_in_nmi(void)
>   {
> @@ -471,6 +475,7 @@ static inline int bpf_in_nmi(void)
>    *	* powerpc64
>    *	* s390x
>    *	* loongarch
> + *	* riscv
>    */
>   static inline int bpf_in_hardirq(void)
>   {
> @@ -484,6 +489,7 @@ static inline int bpf_in_hardirq(void)
>    *	* powerpc64
>    *	* s390x
>    *	* loongarch
> + *	* riscv
>    */
>   static inline int bpf_in_serving_softirq(void)
>   {
> @@ -505,6 +511,7 @@ static inline int bpf_in_serving_softirq(void)
>    *	* powerpc64
>    *	* s390x
>    *	* loongarch
> + *	* riscv
>    */
>   static inline int bpf_in_task(void)
>   {

  reply	other threads:[~2026-07-22  2:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-22  2:29 Tiezhu Yang
2026-07-22  2:51 ` Pu Lehui [this message]
2026-07-24 21:00 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14216058-3e55-4225-819f-9fce6ab7dffb@huawei.com \
    --to=pulehui@huawei.com \
    --cc=andrii@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=eddyz87@gmail.com \
    --cc=ihor.solodrai@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yangtiezhu@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®