From: Li Bin <huawei.libin@huawei.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>,
Seth Jennings <sjenning@redhat.com>,
Jiri Kosina <jkosina@suse.cz>, Vojtech Pavlik <vojtech@suse.cz>,
Jiri Slaby <jslaby@suse.cz>, Miroslav Benes <mbenes@suse.cz>
Cc: <live-patching@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<lizefan@huawei.com>, <guohanjun@huawei.com>,
<zhangdianfang@huawei.com>, <xiexiuqi@huawei.com>
Subject: [PATCH 1/2] livepatch: Revert "livepatch: enforce patch stacking semantics"
Date: Wed, 21 Jan 2015 17:07:41 +0800 [thread overview]
Message-ID: <1421831262-27869-2-git-send-email-huawei.libin@huawei.com> (raw)
In-Reply-To: <1421831262-27869-1-git-send-email-huawei.libin@huawei.com>
This reverts commit 83a90bb1345767f0cb96d242fd8b9db44b2b0e17.
The method that only allowing the topmost patch on the stack to be
enabled or disabled is unreasonable. Such as the following case:
- do live patch1
- disable patch1
- do live patch2 //error
Now, we will never be able to do new live patch unless disabing the
patch1 although there is no dependencies.
Signed-off-by: Li Bin <huawei.libin@huawei.com>
---
kernel/livepatch/core.c | 10 ----------
1 files changed, 0 insertions(+), 10 deletions(-)
diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
index bc05d39..7861ed2 100644
--- a/kernel/livepatch/core.c
+++ b/kernel/livepatch/core.c
@@ -468,11 +468,6 @@ static int __klp_disable_patch(struct klp_patch *patch)
struct klp_object *obj;
int ret;
- /* enforce stacking: only the last enabled patch can be disabled */
- if (!list_is_last(&patch->list, &klp_patches) &&
- list_next_entry(patch, list)->state == KLP_ENABLED)
- return -EBUSY;
-
pr_notice("disabling patch '%s'\n", patch->mod->name);
for (obj = patch->objs; obj->funcs; obj++) {
@@ -529,11 +524,6 @@ static int __klp_enable_patch(struct klp_patch *patch)
if (WARN_ON(patch->state != KLP_DISABLED))
return -EINVAL;
- /* enforce stacking: only the first disabled patch can be enabled */
- if (patch->list.prev != &klp_patches &&
- list_prev_entry(patch, list)->state == KLP_DISABLED)
- return -EBUSY;
-
pr_notice_once("tainting kernel with TAINT_LIVEPATCH\n");
add_taint(TAINT_LIVEPATCH, LOCKDEP_STILL_OK);
--
1.7.1
next prev parent reply other threads:[~2015-01-21 9:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 9:07 [PATCH 0/2] disable/enable_patch manners for interdependent patches Li Bin
2015-01-21 9:07 ` Li Bin [this message]
2015-01-21 14:06 ` [PATCH 1/2] livepatch: Revert "livepatch: enforce patch stacking semantics" Jiri Kosina
2015-01-21 14:36 ` Seth Jennings
2015-01-22 0:44 ` Li Bin
2015-01-22 1:01 ` Li Bin
2015-01-22 9:15 ` Miroslav Benes
2015-01-22 9:42 ` Li Bin
2015-01-21 9:07 ` [PATCH 2/2] livepatch: disable/enable_patch manners for interdependent patches Li Bin
2015-01-21 14:08 ` Jiri Kosina
2015-01-22 0:42 ` Li Bin
2015-01-22 3:51 ` Josh Poimboeuf
2015-01-22 8:39 ` Li Bin
2015-01-22 9:54 ` Li Bin
2015-01-22 13:05 ` Josh Poimboeuf
2015-01-23 1:08 ` Li Bin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421831262-27869-2-git-send-email-huawei.libin@huawei.com \
--to=huawei.libin@huawei.com \
--cc=guohanjun@huawei.com \
--cc=jkosina@suse.cz \
--cc=jpoimboe@redhat.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mbenes@suse.cz \
--cc=sjenning@redhat.com \
--cc=vojtech@suse.cz \
--cc=xiexiuqi@huawei.com \
--cc=zhangdianfang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®