From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753401AbbAUShU (ORCPT ); Wed, 21 Jan 2015 13:37:20 -0500 Received: from mail-ie0-f173.google.com ([209.85.223.173]:56707 "EHLO mail-ie0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750917AbbAUShQ (ORCPT ); Wed, 21 Jan 2015 13:37:16 -0500 Message-ID: <1421865423.4832.28.camel@edumazet-glaptop2.roam.corp.google.com> Subject: Re: [PATCH v2] net: stmmac: add BQL support From: Eric Dumazet To: Beniamino Galvani Cc: "David S. Miller" , Giuseppe Cavallaro , Florian Fainelli , Dave Taht , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 21 Jan 2015 10:37:03 -0800 In-Reply-To: <1421863647-20048-1-git-send-email-b.galvani@gmail.com> References: <1421863647-20048-1-git-send-email-b.galvani@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-01-21 at 19:07 +0100, Beniamino Galvani wrote: > Add support for Byte Queue Limits to the STMicro MAC driver. > > Tested on a Amlogic S802 quad Cortex-A9 board, where the use of BQL > decreases the latency of a high priority ping from ~12ms to ~1ms when > the 100Mbit link is saturated by 20 TCP streams. > > Signed-off-by: Beniamino Galvani > --- > Changes since v1: > - don't access skb->len after the start of DMA transmission in > stmmac_xmit(), to avoid potential use after free in case tx_lock is > removed in the future > > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 9 +++++++++ > 1 file changed, 9 insertions(+) Reviewed-by: Eric Dumazet Thanks !