From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753851AbbAUVei (ORCPT ); Wed, 21 Jan 2015 16:34:38 -0500 Received: from 7of9.schinagl.nl ([88.159.158.68]:39409 "EHLO 7of9.schinagl.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752308AbbAUVeR (ORCPT ); Wed, 21 Jan 2015 16:34:17 -0500 From: Olliver Schinagl To: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Linus Walleij , Alexandre Courbot , Dmitry Torokhov , Bryan Wu , Richard Purdie , Olliver Schinagl , Robin Gong , Mika Westerberg , Aaron Lu , Grant Likely , Jingoo Han , Alexander Shiyan , Wolfram Sang Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org Subject: [PATCH v2 1/4] gpio: use sizeof() instead of hardcoded values Date: Wed, 21 Jan 2015 22:33:45 +0100 Message-Id: <1421876028-22799-2-git-send-email-o.schinagl@ultimaker.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1421876028-22799-1-git-send-email-o.schinagl@ultimaker.com> References: <1421876028-22799-1-git-send-email-o.schinagl@ultimaker.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Olliver Schinagl gpiolib uses a fixed string for the suffixes and defines it at 32 bytes. Later in the code snprintf is used with this fixed value of 32. Using sizeof() is safer in case the size for the suffixes is ever changed. Signed-off-by: Olliver Schinagl --- drivers/gpio/gpiolib.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index c926641..bf6016d 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -1665,9 +1665,11 @@ static struct gpio_desc *of_find_gpio(struct device *dev, const char *con_id, for (i = 0; i < ARRAY_SIZE(suffixes); i++) { if (con_id) - snprintf(prop_name, 32, "%s-%s", con_id, suffixes[i]); + snprintf(prop_name, sizeof(prop_name), "%s-%s", con_id, + suffixes[i]); else - snprintf(prop_name, 32, "%s", suffixes[i]); + snprintf(prop_name, sizeof(prop_name), "%s", + suffixes[i]); desc = of_get_named_gpiod_flags(dev->of_node, prop_name, idx, &of_flags); -- 2.1.4