From: John Stultz <john.stultz@linaro.org>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: John Stultz <john.stultz@linaro.org>,
Dave Jones <davej@codemonkey.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Richard Cochran <richardcochran@gmail.com>,
Prarit Bhargava <prarit@redhat.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
"David S. Miller" <davem@davemloft.net>
Subject: [PATCH 11/12] sparc: Convert to using clocksource_register_hz()
Date: Thu, 22 Jan 2015 16:09:26 -0800 [thread overview]
Message-ID: <1421971767-17707-12-git-send-email-john.stultz@linaro.org> (raw)
In-Reply-To: <1421971767-17707-1-git-send-email-john.stultz@linaro.org>
While cleaning up some clocksource code, I noticed the
time_32 impelementation uses the hz2mult helper, but
doesn't use the clocksource_register_hz() method.
I don't believe the sparc clocksource is a default
clocksource, so we shouldn't need to self-define
the mult/shift pair.
So convert the time_32.c implementation to use
clocksource_register_hz().
Untested.
Cc: Dave Jones <davej@codemonkey.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Richard Cochran <richardcochran@gmail.com>
Cc: Prarit Bhargava <prarit@redhat.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: John Stultz <john.stultz@linaro.org>
---
arch/sparc/kernel/time_32.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/arch/sparc/kernel/time_32.c b/arch/sparc/kernel/time_32.c
index a31c0c8..18147a5 100644
--- a/arch/sparc/kernel/time_32.c
+++ b/arch/sparc/kernel/time_32.c
@@ -181,17 +181,13 @@ static struct clocksource timer_cs = {
.rating = 100,
.read = timer_cs_read,
.mask = CLOCKSOURCE_MASK(64),
- .shift = 2,
.flags = CLOCK_SOURCE_IS_CONTINUOUS,
};
static __init int setup_timer_cs(void)
{
timer_cs_enabled = 1;
- timer_cs.mult = clocksource_hz2mult(sparc_config.clock_rate,
- timer_cs.shift);
-
- return __clocksource_register(&timer_cs);
+ return clocksource_register_hz(&timer_cs, sparc_config.clock_rate);
}
#ifdef CONFIG_SMP
--
1.9.1
next prev parent reply other threads:[~2015-01-23 0:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 0:09 [PATCH 00/12][RFC] Increased clocksource validation and cleanups (v2) John Stultz
2015-01-23 0:09 ` [PATCH 01/12] clocksource: Simplify clocks_calc_max_nsecs logic John Stultz
2015-01-23 0:09 ` [PATCH 02/12] clocksource: Simplify logic around clocksource wrapping saftey margins John Stultz
2015-01-23 0:09 ` [PATCH 03/12] clocksource: Remove clocksource_max_deferment() John Stultz
2015-01-23 0:09 ` [PATCH 04/12] clocksource: Add max_cycles to clocksource structure John Stultz
2015-01-23 0:09 ` [PATCH 05/12] time: Add debugging checks to warn if we see delays John Stultz
2015-01-23 14:27 ` Peter Zijlstra
2015-01-23 0:09 ` [PATCH 06/12] time: Add infrastructure to cap clocksource reads to the max_cycles value John Stultz
2015-01-23 14:28 ` Peter Zijlstra
2015-01-24 17:35 ` Richard Cochran
2015-01-23 0:09 ` [PATCH 07/12] time: Try to catch clocksource delta underflows John Stultz
2015-01-23 0:09 ` [PATCH 08/12] time: Add warnings when overflows or underflows are observed John Stultz
2015-01-23 14:30 ` Peter Zijlstra
2015-01-23 0:09 ` [PATCH 09/12] clocksource: Improve clocksource watchdog reporting John Stultz
2015-01-23 0:09 ` [PATCH 10/12] clocksource: Mostly kill clocksource_register() John Stultz
2015-01-23 0:09 ` John Stultz [this message]
2015-01-27 1:18 ` [PATCH 11/12] sparc: Convert to using clocksource_register_hz() David Miller
2015-01-23 0:09 ` [PATCH 12/12] clocksource: Add some debug info about clocksources being registered John Stultz
2015-03-07 2:49 [PATCH 00/12] Increased clocksource validation and cleanups (v3) John Stultz
2015-03-07 2:50 ` [PATCH 11/12] sparc: Convert to using clocksource_register_hz() John Stultz
2015-03-07 9:46 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421971767-17707-12-git-send-email-john.stultz@linaro.org \
--to=john.stultz@linaro.org \
--cc=davej@codemonkey.org.uk \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=prarit@redhat.com \
--cc=richardcochran@gmail.com \
--cc=sboyd@codeaurora.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome