From: Peter Rosin <peda@lysator.liu.se>
To: alsa-devel@alsa-project.org
Cc: Peter Rosin <peda@axentia.se>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.de>,
Lars-Peter Clausen <lars@metafoo.de>,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] ASoC: pcm512x: Use the correct range constraints for S24_LE
Date: Thu, 29 Jan 2015 12:21:56 +0100 [thread overview]
Message-ID: <1422530516-21779-3-git-send-email-peda@lysator.liu.se> (raw)
In-Reply-To: <1422530516-21779-1-git-send-email-peda@lysator.liu.se>
From: Peter Rosin <peda@axentia.se>
This was overlooked in the late change to remove the I2S padding bits
from S24_LE mode. The patch also limits S32_LE mode to 384kHz, the
maximum according to the datasheets.
Signed-off-by: Peter Rosin <peda@axentia.se>
---
sound/soc/codecs/pcm512x.c | 39 ++++++++++++++++++++-------------------
1 file changed, 20 insertions(+), 19 deletions(-)
diff --git a/sound/soc/codecs/pcm512x.c b/sound/soc/codecs/pcm512x.c
index 067d11743c31..884784fb1566 100644
--- a/sound/soc/codecs/pcm512x.c
+++ b/sound/soc/codecs/pcm512x.c
@@ -356,36 +356,37 @@ static const struct snd_pcm_hw_constraint_list constraints_slave = {
.list = pcm512x_dai_rates,
};
-static const struct snd_interval pcm512x_dai_ranges_64bpf[] = {
- {
- .min = 8000,
- .max = 195312,
- }, {
- .min = 250000,
- .max = 390625,
- },
-};
-
-static struct snd_pcm_hw_constraint_ranges constraints_64bpf = {
- .count = ARRAY_SIZE(pcm512x_dai_ranges_64bpf),
- .ranges = pcm512x_dai_ranges_64bpf,
-};
-
static int pcm512x_hw_rule_rate(struct snd_pcm_hw_params *params,
struct snd_pcm_hw_rule *rule)
{
- struct snd_pcm_hw_constraint_ranges *r = rule->private;
+ struct snd_interval ranges[2];
int frame_size;
frame_size = snd_soc_params_to_frame_size(params);
if (frame_size < 0)
return frame_size;
- if (frame_size != 64)
+ switch (frame_size) {
+ case 32:
+ /* No hole when the frame size is 32. */
return 0;
+ case 48:
+ case 64:
+ /* There is only one hole in the range of supported
+ * rates, but it moves with the frame size.
+ */
+ memset(ranges, 0, sizeof(ranges));
+ ranges[0].min = 8000;
+ ranges[0].max = 25000000 / frame_size / 2;
+ ranges[1].min = DIV_ROUND_UP(16000000, frame_size);
+ ranges[1].max = 384000;
+ break;
+ default:
+ return -EINVAL;
+ }
return snd_interval_ranges(hw_param_interval(params, rule->var),
- r->count, r->ranges, r->mask);
+ ARRAY_SIZE(ranges), ranges, 0);
}
static int pcm512x_dai_startup_master(struct snd_pcm_substream *substream,
@@ -407,7 +408,7 @@ static int pcm512x_dai_startup_master(struct snd_pcm_substream *substream,
return snd_pcm_hw_rule_add(substream->runtime, 0,
SNDRV_PCM_HW_PARAM_RATE,
pcm512x_hw_rule_rate,
- (void *)&constraints_64bpf,
+ NULL,
SNDRV_PCM_HW_PARAM_FRAME_BITS,
SNDRV_PCM_HW_PARAM_CHANNELS, -1);
--
1.7.10.4
next prev parent reply other threads:[~2015-01-29 11:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 11:21 [PATCH 0/2] ASoC: pcm512x: Fixups for the Clock master modes series Peter Rosin
2015-01-29 11:21 ` [PATCH 1/2] ASoC: pcm512x: Fixup warning splat Peter Rosin
2015-01-29 11:21 ` Peter Rosin [this message]
2015-01-29 12:02 ` [PATCH 0/2] ASoC: pcm512x: Fixups for the Clock master modes series Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422530516-21779-3-git-send-email-peda@lysator.liu.se \
--to=peda@lysator.liu.se \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®