From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759474AbbA3CTl (ORCPT ); Thu, 29 Jan 2015 21:19:41 -0500 Received: from ozlabs.org ([103.22.144.67]:34095 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752517AbbA3CTk (ORCPT ); Thu, 29 Jan 2015 21:19:40 -0500 Message-ID: <1422584378.13284.3.camel@ellerman.id.au> Subject: Re: [PATCHv2 0/8] Fix perf probe issues on powerpc From: Michael Ellerman To: "Naveen N. Rao" Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, acme@kernel.org, ananth@in.ibm.com Date: Fri, 30 Jan 2015 13:19:38 +1100 In-Reply-To: <20150128064302.GB2078@naverao1-tp.in.ibm.com> References: <20150128054245.GA2078@naverao1-tp.in.ibm.com> <1422425662.11009.3.camel@ellerman.id.au> <20150128064302.GB2078@naverao1-tp.in.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.7-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2015-01-28 at 12:13 +0530, Naveen N. Rao wrote: > On 2015/01/28 05:14PM, Michael Ellerman wrote: > > On Wed, 2015-01-28 at 11:12 +0530, Naveen N. Rao wrote: > > > On 2014/12/15 08:20PM, Naveen N Rao wrote: > > > > This patchset fixes various issues with perf probe on powerpc across ABIv1 and > > > > ABIv2: > > > > - in the presence of DWARF debug-info, > > > > - in the absence of DWARF, but with the symbol table, and > > > > - in the absence of debug-info, but with kallsyms. > > > > > > > > Applies cleanly on -tip. Tested on ppc64 BE and LE. > > > > > > > > Changes from previous version: > > > > Addressed various review comments from Mike Ellerman largely to generalize > > > > changes. Some of the simpler patches have been retained in their previous form > > > > to limit code churn, while others have been generalized by introducing arch > > > > helpers. Individual patches have more details. > > > > > > Michael, > > > Can you please take a quick look at this? > > > > I merged patch 1. > > > > https://git.kernel.org/cgit/linux/kernel/git/mpe/linux.git/commit/?h=next&id=bf794bf52a80c6278a028f0af2ca32d7c3508c9b > > > > The rest are not for me, they're perf tools, so you need to convince acme > > they're good. > > Oh, thanks! Sorry, I didn't realize you had already merged it. > I assume you are ok with my changes in v2 w.r.t your previous review > comments. Yeah it looks like you addressed most of my comments. cheers