From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755348AbbAaA0U (ORCPT ); Fri, 30 Jan 2015 19:26:20 -0500 Received: from mail.kmu-office.ch ([178.209.48.109]:49096 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752160AbbAaA0T (ORCPT ); Fri, 30 Jan 2015 19:26:19 -0500 From: Stefan Agner To: tglx@linutronix.de, jason@lakedaemon.net Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stefan@agner.ch Subject: [PATCH] irqchip: gic: ignore empty processor target registers Date: Sat, 31 Jan 2015 01:26:10 +0100 Message-Id: <1422663970-3563-1-git-send-email-stefan@agner.ch> X-Mailer: git-send-email 2.2.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On initialization time, the GIC driver reads the processor target register (ICDIPTR) to determine the CPU's mask. On uniprocessor systems with GIC controller (e.g. Cortex-A5 SoC's) this register is RAZ/WI and hence the mask ends up being zero. This leads to the somewhat confusing boot message: [ 0.000000] GIC CPU mask not found - kernel will fail to boot. To avoid the message, print the error only on SMP systems. Signed-off-by: Stefan Agner --- I would like to get rid of this critical message in my bootlog, it sounds somewhat... intimidating... Actually the driver could also conditionally avoid setting up GIC_DIST_TARGET, since it's RAZ/WI (write ignored) on uniprocessor systems. But I'm not sure if is_smp() is really reflecting all SoC's using GIC which need the Interrupt Processor Targets register configured. drivers/irqchip/irq-gic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c index d617ee5..7d4f0f5 100644 --- a/drivers/irqchip/irq-gic.c +++ b/drivers/irqchip/irq-gic.c @@ -346,7 +346,7 @@ static u8 gic_get_cpumask(struct gic_chip_data *gic) break; } - if (!mask) + if (!mask && is_smp()) pr_crit("GIC CPU mask not found - kernel will fail to boot.\n"); return mask; -- 2.2.2