From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753240AbbBANGU (ORCPT ); Sun, 1 Feb 2015 08:06:20 -0500 Received: from www.osadl.org ([62.245.132.105]:42537 "EHLO www.osadl.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752905AbbBANGS (ORCPT ); Sun, 1 Feb 2015 08:06:18 -0500 From: Nicholas Mc Guire To: Laxman Dewangan Cc: Mark Brown , Stephen Warren , Thierry Reding , Alexandre Courbot , linux-spi@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, Nicholas Mc Guire Subject: [PATCH 2/2] spi: tegra20-slink: cleanup wait_for_completion return handling Date: Sun, 1 Feb 2015 08:02:07 -0500 Message-Id: <1422795727-29097-1-git-send-email-hofrat@osadl.org> X-Mailer: git-send-email 1.7.10.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org return type of wait_for_completion_timeout is unsigned long not int, this patch adds an appropriate variable and fixes up the assignment. As the string in dev_err already states "timeout" there is little point in printing the 0 here as it just restates "timeout". Signed-off-by: Nicholas Mc Guire --- This patch was only compile tested with tegra_defconfig (implies CONFIG_SPI_TEGRA20_SLINK=y) Patch is against 3.19.0-rc6 -next-20150130 drivers/spi/spi-tegra20-slink.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-tegra20-slink.c b/drivers/spi/spi-tegra20-slink.c index 85c91f5..106afe1 100644 --- a/drivers/spi/spi-tegra20-slink.c +++ b/drivers/spi/spi-tegra20-slink.c @@ -811,6 +811,7 @@ static int tegra_slink_transfer_one(struct spi_master *master, { struct tegra_slink_data *tspi = spi_master_get_devdata(master); int ret; + unsigned long dma_timeout; reinit_completion(&tspi->xfer_completion); ret = tegra_slink_start_transfer_one(spi, xfer); @@ -820,11 +821,10 @@ static int tegra_slink_transfer_one(struct spi_master *master, return ret; } - ret = wait_for_completion_timeout(&tspi->xfer_completion, + dma_timeout = wait_for_completion_timeout(&tspi->xfer_completion, SLINK_DMA_TIMEOUT); - if (WARN_ON(ret == 0)) { - dev_err(tspi->dev, - "spi trasfer timeout, err %d\n", ret); + if (WARN_ON(dma_timeout == 0)) { + dev_err(tspi->dev, "spi trasfer timeout\n"); return -EIO; } -- 1.7.10.4