From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753644AbbBBBB2 (ORCPT <rfc822;w@1wt.eu>);
	Sun, 1 Feb 2015 20:01:28 -0500
Received: from ozlabs.org ([103.22.144.67]:36461 "EHLO ozlabs.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752500AbbBBBBZ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sun, 1 Feb 2015 20:01:25 -0500
Message-ID: <1422838882.11325.1.camel@ellerman.id.au>
Subject: Re: [PATCH] cxl: remove redundant increment of hwirq
From: Michael Ellerman <mpe@ellerman.id.au>
To: Colin King <colin.king@canonical.com>
Cc: Ian Munsie <imunsie@au1.ibm.com>, Michael Neuling <mikey@neuling.org>,
        linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Date: Mon, 02 Feb 2015 12:01:22 +1100
In-Reply-To: <1422826808-31363-1-git-send-email-colin.king@canonical.com>
References: <1422826808-31363-1-git-send-email-colin.king@canonical.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.7-0ubuntu1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, 2015-02-01 at 21:40 +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Recent commit 80fa93fce37d3490f
> ("cxl: Name interrupts in /proc/interrupt") introduced a
> redundant increment of hwirq which is not used or even
> initialised at the point it is incremented. Detected by
> cppcheck:
> 
> [drivers/misc/cxl/irq.c:439]: (error) Uninitialized
>   variable: hwirq
> 
> Simple fix, remove the redundant increment.

This looks more or less the same as the previous patch you sent? The one which
has been in my next branch for 11 days?

cheers