From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932656AbbBBGj2 (ORCPT ); Mon, 2 Feb 2015 01:39:28 -0500 Received: from ozlabs.org ([103.22.144.67]:47820 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932486AbbBBGj0 (ORCPT ); Mon, 2 Feb 2015 01:39:26 -0500 Message-ID: <1422859164.20278.1.camel@ellerman.id.au> Subject: Re: [PATCH V3] cpuidle/powernv: Read target_residency value of idle states from DT if available From: Michael Ellerman To: Preeti U Murthy Cc: stewart@linux.vnet.ibm.com, rafael.j.wysocki@intel.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Date: Mon, 02 Feb 2015 17:39:24 +1100 In-Reply-To: <20150202050821.24581.56186.stgit@preeti.in.ibm.com> References: <20150202050821.24581.56186.stgit@preeti.in.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.7-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-02-02 at 10:40 +0530, Preeti U Murthy wrote: > The device tree now exposes the residency values for different idle states. Read > these values instead of calculating residency from the latency values. The values > exposed in the DT are validated for optimal power efficiency. However to maintain > compatibility with the older firmware code which does not expose residency > values, use default values as a fallback mechanism. While at it, use better > APIs to parse the powermgmt device tree node so as to avoid endianness > transformation. > > Signed-off-by: Preeti U Murthy > --- > Changes from V2: https://lkml.org/lkml/2015/1/27/1054 > 1. Used APIs to eliminate endianness transformation Hi Preeti, I thought I was pretty clear when I said you should do that as a follow-up patch. This is now doing too many things, it's not a single logical change, and it's touching code in arch/powerpc and the driver. Which means neither I nor Rafael can easily merge it. So please go back to the v2 you had. And then do the of_property_count_u32_elems() changes as separate patches. cheers